Move librustc to 2018 #58193
Merged
Move librustc to 2018 #58193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
mark-i-m
commented
Feb 5, 2019
| // results in a bunch of "failed to resolve" errors. Hopefully, the compiler moves to serde or | ||
| // something, and we can get rid of this. | ||
| #[allow(rust_2018_idioms)] | ||
| extern crate serialize as rustc_serialize; |
There was a problem hiding this comment.
I want to draw attention to this ^^^
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
fixed tidy |
|
@bors r+ |
|
📌 Commit e957ed9 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=2 |
|
⌛ Testing commit e957ed9 with merge f46c577d72fb355f1734383f2423affcae63e4fa... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Ugh looks like a spurious failure (timeout?) of the very last CI task... |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 7, 2019
Move librustc to 2018 r? @Centril Part of rust-lang#58099 It would be great to get this reviewed quickly to avoid merge conflicts...
bors
added a commit
that referenced
this pull request
Feb 7, 2019
Rollup of 23 pull requests Successful merges: - #58118 (Transition libtest to 2018 edition) - #58119 (libproc_macro => 2018) - #58123 (Avoid some bounds checks in binary_heap::{PeekMut,Hole}) - #58124 (libsyntax_pos => 2018) - #58133 (libsyntax_ext => 2018) - #58136 (Improve error message and docs for non-UTF-8 bytes in stdio on Windows) - #58156 (update submodule: rust-installer from 27dec6c to ccdc47b) - #58192 (Do not ICE in codegen when using a extern_type static) - #58193 (Move librustc to 2018) - #58210 (Make an assert debug-only in `find_constraint_paths_between_regions`.) - #58217 (librustc_tsan => 2018) - #58218 (librustc_msan => 2018) - #58219 (librustc_asan => 2018) - #58220 (libprofiler_builtins => 2018) - #58223 (librustc_lsan => 2018) - #58225 (librustc_fs_util => 2018) - #58228 (librustc_plugin => 2018) - #58236 (librustc_resolve => 2018) - #58237 (Fix broken grammar in iter::from_fn() docs) - #58239 (librustc_apfloat => 2018) - #58240 (librustc_errors => 2018) - #58241 (librustc_llvm => 2018) - #58242 (Document the one TyKind that isn't documented) Failed merges: - #58185 (Remove images' url to make it work even without internet connection) r? @ghost
78 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Centril
Part of #58099
It would be great to get this reviewed quickly to avoid merge conflicts...