Add specific feature gate error for const-unstable features #58196

varkor · 2019-02-05T20:29:05Z

Before:

error: `impl Trait` in const fn is unstable
 --> src/lib.rs:7:19
  |
7 | const fn foo() -> impl T {
  |                   ^^^^^^

error: aborting due to previous error

After:

error[E0723]: `impl Trait` in const fn is unstable (see issue #57563)
 --> src/lib.rs:7:19
  |
7 | const fn foo() -> impl T {
  |                   ^^^^^^
  = help: add #![feature(const_fn)] to the crate attributes to enable

error: aborting due to previous error

This improves the situation with #57563. Fixes #57544. Fixes #54469.

r? @oli-obk

oli-obk

r=me with a documentation nit

src/librustc_mir/diagnostics.rs

varkor · 2019-02-05T21:03:19Z

@bors r=oli-obk

bors · 2019-02-05T21:03:20Z

📌 Commit 4ed4c99cfce30b03d0873aa6b1fbd9e133056132 has been approved by oli-obk

kennytm · 2019-02-07T14:39:03Z

@bors r=oli-obk

Please tell bors about the re-approval after a force-push.

bors · 2019-02-07T14:39:04Z

📌 Commit 8a7df4f has been approved by oli-obk

@oli-obk

… r=oli-obk Add specific feature gate error for const-unstable features Before: ``` error: `impl Trait` in const fn is unstable --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ error: aborting due to previous error ``` After: ``` error[E0723]: `impl Trait` in const fn is unstable (see issue rust-lang#57563) --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ = help: add #![feature(const_fn)] to the crate attributes to enable error: aborting due to previous error ``` This improves the situation with rust-lang#57563. Fixes rust-lang#57544. Fixes rust-lang#54469. r? @oli-obk

@oli-obk

… r=oli-obk Add specific feature gate error for const-unstable features Before: ``` error: `impl Trait` in const fn is unstable --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ error: aborting due to previous error ``` After: ``` error[E0723]: `impl Trait` in const fn is unstable (see issue rust-lang#57563) --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ = help: add #![feature(const_fn)] to the crate attributes to enable error: aborting due to previous error ``` This improves the situation with rust-lang#57563. Fixes rust-lang#57544. Fixes rust-lang#54469. r? @oli-obk

@ghost

Rollup of 13 pull requests Successful merges: - #57693 (Doc rewording) - #57815 (Speed up the fast path for assert_eq! and assert_ne!) - #58034 (Stabilize the time_checked_add feature) - #58057 (Stabilize linker-plugin based LTO (aka cross-language LTO)) - #58137 (Cleanup: rename node_id_to_type(_opt)) - #58166 (allow shorthand syntax for deprecation reason) - #58196 (Add specific feature gate error for const-unstable features) - #58200 (fix str mutating through a ptr derived from &self) - #58273 (Rename rustc_errors dependency in rust 2018 crates) - #58289 (impl iter() for dyn Error) - #58387 (Disallow `auto` trait alias syntax) - #58404 (use Ubuntu keyserver for CloudABI ports) - #58405 (Remove some dead code from libcore) Failed merges: r? @ghost

Centril · 2019-02-13T03:34:39Z

Failed in rollup (#58413 (comment)), @bors r- ; to fix the issue, try --bless --compare-mode=nll.

varkor · 2019-02-14T15:47:58Z

@bors r=oli-obk

bors · 2019-02-14T15:47:59Z

📌 Commit 8ca4406 has been approved by oli-obk

@oli-obk

… r=oli-obk Add specific feature gate error for const-unstable features Before: ``` error: `impl Trait` in const fn is unstable --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ error: aborting due to previous error ``` After: ``` error[E0723]: `impl Trait` in const fn is unstable (see issue rust-lang#57563) --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ = help: add #![feature(const_fn)] to the crate attributes to enable error: aborting due to previous error ``` This improves the situation with rust-lang#57563. Fixes rust-lang#57544. Fixes rust-lang#54469. r? @oli-obk

@oli-obk

… r=oli-obk Add specific feature gate error for const-unstable features Before: ``` error: `impl Trait` in const fn is unstable --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ error: aborting due to previous error ``` After: ``` error[E0723]: `impl Trait` in const fn is unstable (see issue rust-lang#57563) --> src/lib.rs:7:19 | 7 | const fn foo() -> impl T { | ^^^^^^ = help: add #![feature(const_fn)] to the crate attributes to enable error: aborting due to previous error ``` This improves the situation with rust-lang#57563. Fixes rust-lang#57544. Fixes rust-lang#54469. r? @oli-obk

Rollup of 19 pull requests Successful merges: - #57929 (Rustdoc remove old style files) - #57981 (Fix #57730) - #58074 (Stabilize slice_sort_by_cached_key) - #58196 (Add specific feature gate error for const-unstable features) - #58293 (Remove code for updating copyright years in generate-deriving-span-tests) - #58306 (Don't default on std crate when manipulating browser history) - #58359 (librustc_mir: use ? in impl_snapshot_for! macro) - #58395 (Instant::checked_duration_since) - #58429 (fix Box::into_unique effecitvely transmuting to a raw ptr) - #58433 (Update which libcore/liballoc tests Miri ignores, and document why) - #58438 (Use posix_spawn_file_actions_addchdir_np when possible) - #58440 (Whitelist the ARM v6 target-feature) - #58448 (rustdoc: mask `compiler_builtins` docs) - #58468 (split MaybeUninit into several features, expand docs a bit) - #58477 (Fix the syntax error in publish_toolstate.py) - #58479 (compile-pass test for #53606) - #58489 (Fix runtime error in generate-keyword-tests) - #58496 (Fix documentation for std::path::PathBuf::pop) - #58509 (Notify myself when Clippy toolstate changes)

Rollup of 19 pull requests Successful merges: - #57929 (Rustdoc remove old style files) - #57981 (Fix #57730) - #58074 (Stabilize slice_sort_by_cached_key) - #58196 (Add specific feature gate error for const-unstable features) - #58293 (Remove code for updating copyright years in generate-deriving-span-tests) - #58306 (Don't default on std crate when manipulating browser history) - #58359 (librustc_mir: use ? in impl_snapshot_for! macro) - #58395 (Instant::checked_duration_since) - #58429 (fix Box::into_unique effecitvely transmuting to a raw ptr) - #58433 (Update which libcore/liballoc tests Miri ignores, and document why) - #58438 (Use posix_spawn_file_actions_addchdir_np when possible) - #58440 (Whitelist the ARM v6 target-feature) - #58448 (rustdoc: mask `compiler_builtins` docs) - #58468 (split MaybeUninit into several features, expand docs a bit) - #58479 (compile-pass test for #53606) - #58489 (Fix runtime error in generate-keyword-tests) - #58496 (Fix documentation for std::path::PathBuf::pop) - #58509 (Notify myself when Clippy toolstate changes) - #58521 (Fix tracking issue for error iterators)

rust-highfive assigned oli-obk Feb 5, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2019

varkor changed the title ~~Const fn feature gate error~~ Add specific feature gate error for const-unstable features Feb 5, 2019

oli-obk requested changes Feb 5, 2019

View reviewed changes

src/librustc_mir/diagnostics.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2019

This comment has been minimized.

# to view

varkor force-pushed the const-fn-feature-gate-error branch from 4ed4c99 to 8a7df4f Compare February 6, 2019 08:08

oli-obk approved these changes Feb 6, 2019

View reviewed changes

Centril mentioned this pull request Feb 13, 2019

Rollup of 13 pull requests #58412

Closed

Centril mentioned this pull request Feb 13, 2019

Rollup of 13 pull requests #58413

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 13, 2019

rust-lang deleted a comment from bors Feb 13, 2019

varkor added 4 commits February 14, 2019 15:04

Add specific error for unstable const fn features

2c339ae

Update const fn tests

feb3408

Fix documentation typo

519783a

Add updated NLL tests

8ca4406

varkor force-pushed the const-fn-feature-gate-error branch from 8a7df4f to 8ca4406 Compare February 14, 2019 15:47

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 14, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 14, 2019

Centril mentioned this pull request Feb 14, 2019

Rollup of 9 pull requests #58470

Closed

kennytm mentioned this pull request Feb 15, 2019

Rollup of 19 pull requests #58495

Merged

bors merged commit 8ca4406 into rust-lang:master Feb 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add specific feature gate error for const-unstable features #58196

Add specific feature gate error for const-unstable features #58196

varkor commented Feb 5, 2019 •

edited

Loading

oli-obk left a comment

varkor commented Feb 5, 2019

bors commented Feb 5, 2019

This comment has been minimized.

kennytm commented Feb 7, 2019

bors commented Feb 7, 2019

Centril commented Feb 13, 2019

varkor commented Feb 14, 2019

bors commented Feb 14, 2019

Add specific feature gate error for const-unstable features #58196

Add specific feature gate error for const-unstable features #58196

Conversation

varkor commented Feb 5, 2019 • edited Loading

oli-obk left a comment

Choose a reason for hiding this comment

varkor commented Feb 5, 2019

bors commented Feb 5, 2019

This comment has been minimized.

kennytm commented Feb 7, 2019

bors commented Feb 7, 2019

Centril commented Feb 13, 2019

varkor commented Feb 14, 2019

bors commented Feb 14, 2019

varkor commented Feb 5, 2019 •

edited

Loading