Skip to content

Fix rustc_driver swallowing errors when compilation is stopped #58400

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fix rustc_driver swallowing errors when compilation is stopped #58400

merged 1 commit into from
Feb 14, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Feb 12, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Feb 12, 2019

@bors r+

for future reference, this is relevant for clippy and semverver, because their exit code currently is 0 even if errors occurred

@bors
Copy link
Collaborator

bors commented Feb 12, 2019

📌 Commit ad720fc8b786128693a553ec5ee9a09dff8949bf has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Feb 12, 2019

@bors r-

a comment in the code explaining this would be great.

r=me with that

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2019
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 12, 2019

@oli-obk is it easily possible to add a test for this ? I tried for a bit but failed.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 12, 2019

@oli-obk comment added, this is such a tiny change that i've rebased and force-pushed. Hope that's ok.

@oli-obk
Copy link
Contributor

oli-obk commented Feb 12, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 12, 2019

📌 Commit 3a8448c has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Feb 12, 2019

is it easily possible to add a test for this ? I tried for a bit but failed.

I don't think so. Well, not here. We can add it to clippy and that will make the toolstate fail

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge of rust-lang#58400 - gnzlbg:fix_driver, r=oli-obk
df020a7 
Fix rustc_driver swallowing errors when compilation is stopped

r? @oli-obk
@Centril Centril mentioned this pull request Feb 13, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge of rust-lang#58400 - gnzlbg:fix_driver, r=oli-obk
e1c97f2 
Fix rustc_driver swallowing errors when compilation is stopped

r? @oli-obk
@Centril Centril mentioned this pull request Feb 13, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge of rust-lang#58400 - gnzlbg:fix_driver, r=oli-obk
0178f31 
Fix rustc_driver swallowing errors when compilation is stopped

r? @oli-obk
@Centril Centril mentioned this pull request Feb 13, 2019
Merged
bors added a commit that referenced this pull request Feb 13, 2019
@bors
Auto merge of #58432 - Centril:rollup, r=Centril
4772dc8 
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost
@bors bors merged commit 3a8448c into rust-lang:master Feb 14, 2019
@gnzlbg gnzlbg mentioned this pull request Feb 26, 2019
Merged
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 26, 2019 •
edited
Loading

@oli-obk FYI this did fix rust-semverver upstream. We were testing that all tests should succeed, and now some of the tests correctly report an error: rust-lang/rust-semverver#93

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnzlbg @oli-obk @bors @rust-highfive