Skip to content

ManuallyDrop != MaybeUninit #58780

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2019
Merged

ManuallyDrop != MaybeUninit #58780

merged 3 commits into from
Mar 3, 2019

Conversation

RalfJung
Copy link
Member

@rust-highfive

This comment has been minimized.

# to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2019
nagisa
nagisa reviewed Feb 27, 2019
View reviewed changes
@Centril
Copy link
Contributor

Centril commented Feb 27, 2019

r? @nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned withoutboats Feb 27, 2019
@nagisa
Copy link
Member

nagisa commented Feb 27, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 27, 2019

📌 Commit f92c204 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2019
@nagisa
Copy link
Member

nagisa commented Feb 27, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Feb 28, 2019
@Centril
Rollup merge of rust-lang#58780 - RalfJung:manually-drop, r=nagisa
1bd85d2 
ManuallyDrop != MaybeUninit

Cc @Centril
@Centril Centril mentioned this pull request Feb 28, 2019
Closed
Centril
Centril reviewed Feb 28, 2019
View reviewed changes
@Centril
Copy link
Contributor

Centril commented Feb 28, 2019

Failed in #58798 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 28, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Feb 28, 2019 •
edited
Loading

@rust-lang/infra Why did the PR CI not catch that?

@Centril @RalfJung
Update src/libcore/mem.rs
0c1a38c 
Co-Authored-By: RalfJung <post@ralfj.de>
@Centril
Copy link
Contributor

Centril commented Feb 28, 2019

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Feb 28, 2019

📌 Commit 0c1a38c has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 28, 2019
@GuillaumeGomez
Rollup merge of rust-lang#58780 - RalfJung:manually-drop, r=nagisa
9a3e122 
ManuallyDrop != MaybeUninit

Cc @Centril
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 28, 2019
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 1, 2019
@pietroalbini
Rollup merge of rust-lang#58780 - RalfJung:manually-drop, r=nagisa
20409cc 
ManuallyDrop != MaybeUninit

Cc @Centril
@pietroalbini pietroalbini mentioned this pull request Mar 1, 2019
Closed
@kennytm kennytm mentioned this pull request Mar 2, 2019
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 2, 2019
@kennytm
Rollup merge of rust-lang#58780 - RalfJung:manually-drop, r=nagisa
df2b6bc 
ManuallyDrop != MaybeUninit

Cc @Centril
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 2, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#58780 - RalfJung:manually-drop, r=nagisa
4ae4777 
ManuallyDrop != MaybeUninit

Cc @Centril
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 2, 2019
Closed
bors added a commit that referenced this pull request Mar 3, 2019
@bors
Auto merge of #58866 - kennytm:rollup, r=kennytm
f565cdd 
Rollup of 14 pull requests

Successful merges:

 - #58730 (Have all methods of Filter and FilterMap use internal iteration)
 - #58780 (ManuallyDrop != MaybeUninit)
 - #58782 (Replace `s` with `self` in docs for str methods taking self.)
 - #58785 (allow specifying attributes for tool lints)
 - #58802 (Ensure `record_layout_for_printing()` is inlined.)
 - #58821 (Fixed a syntax error in the pin docs)
 - #58830 (tidy: deny(rust_2018_idioms))
 - #58832 (Revert switching to GCP on AppVeyor)
 - #58833 (tools/rustbook: deny(rust_2018_idioms))
 - #58835 (tools/remote-test-{client,server}: deny(rust_2018_idioms))
 - #58838 (Fix typo in Vec#resize_with documentation)
 - #58842 (Forbid duplicating Cargo as a dependency)
 - #58852 (Update toolchain to build NetBSD release)
 - #58865 (Fix C-variadic function printing)
@bors bors merged commit 0c1a38c into rust-lang:master Mar 3, 2019
@nagisa nagisa mentioned this pull request Mar 5, 2019
Closed
@RalfJung RalfJung deleted the manually-drop branch June 10, 2019 11:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nagisa nagisa nagisa left review comments

@Centril Centril Centril left review comments

Assignees

@nagisa nagisa

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rust-highfive @Centril @nagisa @bors @withoutboats