Skip to content

bootstrap: Default to a sensible llvm-suffix. #59173

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2019
Merged

bootstrap: Default to a sensible llvm-suffix. #59173

merged 1 commit into from
Mar 16, 2019

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Mar 14, 2019

I used version-channel-sha, hopefully that should work.

I checked that bootstrap builds, but I cannot check anything else since the llvm
build process is started from cargo, and thus calls clang, and thus I hit the
same bug I hope to fix with this change.

Hopefully fixes #59034.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2019
@emilio emilio mentioned this pull request Mar 14, 2019
Closed
@emilio
Copy link
Contributor Author

emilio commented Mar 14, 2019

cc @Mark-Simulacrum @cuviper

@emilio
Copy link
Contributor Author

emilio commented Mar 14, 2019

Oh, I realize I can let my build progress a bit more if I do CC=gcc CXX=g++ ./x.py build.

@emilio
Copy link
Contributor Author

emilio commented Mar 14, 2019

r? @Mark-Simulacrum

@emilio
bootstrap: Default to a sensible llvm-suffix.
e7b7c41 
I used version-channel-sha, hopefully that should work.

I checked that bootstrap builds, but I cannot check anything else since the llvm
build process is started from cargo, and thus calls clang, and thus I hit the
same bug I hope to fix with this change.

Hopefully fixes rust-lang#59034.
@Mark-Simulacrum
Copy link
Member

Thanks!

I guess we'd need a beta backport to actually fix the in-tree llvm build? Presuming that's the case, let's so @rustbot modify labels: beta-nominated and beta-accepted.

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 14, 2019

📌 Commit e7b7c41 has been approved by Mark-Simulacrum

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 14, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2019
@Centril
Copy link
Contributor

Centril commented Mar 16, 2019

@bors p=7

@kennytm kennytm mentioned this pull request Mar 16, 2019
Merged
@bors bors merged commit e7b7c41 into rust-lang:master Mar 16, 2019
@emilio emilio mentioned this pull request Mar 18, 2019
Open
@emilio emilio deleted the llvm-suffix branch March 18, 2019 12:06
@pietroalbini pietroalbini mentioned this pull request Mar 19, 2019
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 19, 2019
@ehuss ehuss mentioned this pull request Mar 19, 2019
Open
@glandium glandium mentioned this pull request Mar 26, 2019
Closed
@tmiasko tmiasko mentioned this pull request Feb 23, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust's libLLVM-8.so doesn't work with clang
8 participants
@emilio @rust-highfive @Mark-Simulacrum @bors @Centril @alexcrichton @pietroalbini @rustbot