Skip to content

Make meta-item API compatible with LocalInternedString::get soundness fix #59256

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

petrochenkov
Copy link
Contributor

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2019
@Zoxc
Copy link
Contributor

Zoxc commented Mar 18, 2019

The rest of the changes look good to me.

@Zoxc
Copy link
Contributor

Zoxc commented Mar 18, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

📌 Commit db74efc has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019
Make meta-item API compatible with `LocalInternedString::get` soundness fix

r? @Zoxc
@mati865
Copy link
Member

mati865 commented Mar 19, 2019

Smells like broken Clippy (again) 😄

@bors
Copy link
Collaborator

bors commented Mar 25, 2019

⌛ Testing commit db74efc with merge d91b32b...

bors added a commit that referenced this pull request Mar 25, 2019
Make meta-item API compatible with `LocalInternedString::get` soundness fix

r? @Zoxc
@bors
Copy link
Collaborator

bors commented Mar 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Zoxc
Pushing d91b32b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 25, 2019
@bors bors merged commit db74efc into rust-lang:master Mar 25, 2019
@petrochenkov petrochenkov deleted the derval2 branch June 5, 2019 16:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants