Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stabilize refcell_map_split feature #59280

Merged

Conversation

joshlf
Copy link
Contributor

@joshlf joshlf commented Mar 18, 2019

Closes #51476.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2019
@joshlf joshlf force-pushed the sandbox/joshlf/stabilize-refcell-map-split branch from 9d19114 to cb7ec2a Compare March 18, 2019 19:01
@joshlf
Copy link
Contributor Author

joshlf commented Mar 18, 2019

These commits modify submodules.

Fixed.

@cramertj cramertj added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 18, 2019
@cramertj
Copy link
Member

r=me with travis passing.

@joshlf
Copy link
Contributor Author

joshlf commented Mar 18, 2019

@cramertj Travis has passed.

@Centril Centril added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 18, 2019
@Centril Centril added this to the 1.35 milestone Mar 18, 2019
@joshlf joshlf force-pushed the sandbox/joshlf/stabilize-refcell-map-split branch from cb7ec2a to de4be2c Compare March 18, 2019 22:06
@Centril
Copy link
Contributor

Centril commented Mar 18, 2019

@bors r=cramertj,Centril rollup

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

📌 Commit de4be2c has been approved by cramertj,Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019
@Centril Centril assigned cramertj and unassigned nikomatsakis Mar 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019
…cell-map-split, r=cramertj,Centril

Stabilize refcell_map_split feature

Closes rust-lang#51476.
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019
…cell-map-split, r=cramertj,Centril

Stabilize refcell_map_split feature

Closes rust-lang#51476.
bors added a commit that referenced this pull request Mar 19, 2019
Rollup of 11 pull requests

Successful merges:

 - #56348 (Add todo!() macro)
 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #57847 (dbg!() without parameters)
 - #58778 (Implement ExactSizeIterator for ToLowercase and ToUppercase)
 - #58812 (Clarify distinction between floor() and trunc())
 - #58939 (Fix a tiny error in documentation of std::pin.)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)
 - #59252 (add self to mailmap)
 - #59275 (Replaced self-reflective explicit types with clearer `Self` or `Self::…` in stdlib docs)
 - #59280 (Stabilize refcell_map_split feature)
 - #59290 (Run branch cleanup after copy prop)

Failed merges:

r? @ghost
@bors bors merged commit de4be2c into rust-lang:master Mar 19, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants