-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix custom relative libdir #59341
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix custom relative libdir #59341
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
r? @Mark-Simulacrum Could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit but otherwise r=me
@bors r+ |
📌 Commit 480510a863449eeed6ba81f1d9c80724f5daf78a has been approved by |
⌛ Testing commit 480510a863449eeed6ba81f1d9c80724f5daf78a with merge 87ea142e5c95a33b88d86607e94e84d4919d2b9d... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r-
|
I've just caught it myself after rebase: rust-fail.log.gz
But somehow went missed in
|
Looks like it fail because I joined image path with absolute libdir path which results in installation file into itself. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Uses relative libdir to place libraries on all stages. Adds verbose installation output.
Fixed failing. Could you re-review? |
@bors r+ Thanks! |
📌 Commit 5bcc365 has been approved by |
…ulacrum Fix custom relative libdir While working on rust-lang#58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.
⌛ Testing commit 5bcc365 with merge 9969f9d7bef0ef54eac3311e69133fa6dacbdd15... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I've catched #58209 |
@bors retro |
@bors retry |
…ulacrum Fix custom relative libdir While working on rust-lang#58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.
…ulacrum Fix custom relative libdir While working on rust-lang#58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.
Rollup of 4 pull requests Successful merges: - #59166 (resolve: collect trait aliases along with traits) - #59341 (Fix custom relative libdir) - #59446 (Fix stack overflow when generating debuginfo for 'recursive' type) - #59529 (Added documentation on the remainder (Rem) operator for floating points.) Failed merges: r? @ghost
While working on #58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.