#59361 Moved rustc edition opt to short list #59363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
added
T-compiler
|
I'll wait for @rust-lang/compiler discussion, which will probably not happen until next Thursday. |
|
I doubt this needs that much process or consensus from the whole team. Objectively looking at this, it is an obvious improvement. @bors r+ Thanks! |
|
📌 Commit 457a255034873175be33c55edd44863161d25b4c has been approved by |
bors
added
S-waiting-on-bors
|
@peterjoel please adjust the message in your first comment to say |
peterjoel
force-pushed
the
issue_59361_edition_opt_shortlist
branch
from
457a255 to
3eb4eae
Compare
|
@bors r+ Changing the comment, not commit message, would have sufficed but this is also fine. |
|
📌 Commit 3eb4eae has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 28, 2019
…hortlist, r=nagisa rust-lang#59361 Moved rustc edition opt to short list Addresses rust-lang#59361, in case that issue is accepted.
bors
added a commit
that referenced
this pull request
Mar 28, 2019
Rollup of 10 pull requests Successful merges: - #58717 (Add FromStr impl for NonZero types) - #59091 (Combine input and eval_always query types) - #59216 (Type dependent defs wrappers) - #59318 (rustc: Update linker flavor inference from filename) - #59320 (rustc: Allow using `clang` for wasm32 targets) - #59363 (#59361 Moved rustc edition opt to short list) - #59371 (ffi: rename VaList::copy to VaList::with_copy) - #59398 (Add a way to track Rustfix UI test coverage) - #59408 (compiletest: make path normalization smarter) - #59429 (When moving out of a for loop head, suggest borrowing it in nll mode) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #59361, in case that issue is accepted.