Prevent failure in case no space left on device in rustdoc #59734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
ollie27
reviewed
Apr 9, 2019
src/librustdoc/html/render.rs
Outdated
| @@ -1452,11 +1454,12 @@ impl<'a> SourceCollector<'a> { | |||
| let mut href = String::new(); | |||
| clean_srcpath(&self.scx.src_root, &p, false, |component| { | |||
| cur.push(component); | |||
| fs::create_dir_all(&cur).unwrap(); | |||
| fs::create_dir_all(&cur)?; | |||
There was a problem hiding this comment.
fs::create_dir_all(&cur)?; can be moved to after the call to clean_srcpath because create_dir_all works recursively anyway. That means that clean_srcpath itself doesn't need to be modified.
|
r? @ollie27 |
1 similar comment
|
r? @ollie27 |
|
ping from triage @GuillaumeGomez you need to address the review left by ollie above. |
Dylan-DPC-zz
added
S-waiting-on-author
|
Indeed! I'll do it as soon as possible. |
GuillaumeGomez
force-pushed
the
improve-rustdoc-failure
branch
from
b32b83a to
feb5a53
Compare
|
Updated (thanks for the great suggestion @ollie27!). |
|
Looks good. @bors r+ rollup |
|
📌 Commit feb5a53 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 25, 2019
…ure, r=ollie27 Prevent failure in case no space left on device in rustdoc Fixes rust-lang#59703. r? @QuietMisdreavus
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 25, 2019
…ure, r=ollie27 Prevent failure in case no space left on device in rustdoc Fixes rust-lang#59703. r? @QuietMisdreavus
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 26, 2019
…ure, r=ollie27 Prevent failure in case no space left on device in rustdoc Fixes rust-lang#59703. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Apr 26, 2019
Rollup of 12 pull requests Successful merges: - #59734 (Prevent failure in case no space left on device in rustdoc) - #59940 (Set cfg(test) when rustdoc is running with --test option) - #60134 (Fix index-page generation) - #60165 (Add Pin::{into_inner,into_inner_unchecked}) - #60183 (Chalkify: Add builtin Copy/Clone) - #60225 (Introduce hir::ExprKind::Use and employ in for loop desugaring.) - #60247 (Implement Debug for Place using Place::iterate) - #60259 (Derive Default instead of new in applicable lint) - #60267 (Add feature-gate for f16c target feature) - #60284 (Do not allow const generics to depend on type parameters) - #60285 (Do not ICE when checking types against foreign fn) - #60289 (Make `-Z allow-features` work for stdlib features) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59703.
r? @QuietMisdreavus