Skip to content

Rollup of 7 pull requests #59967

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 19 commits into from
Apr 14, 2019
Merged

Rollup of 7 pull requests #59967

merged 19 commits into from
Apr 14, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Apr 14, 2019

Successful merges:

Failed merges:

r? @ghost

Albin Stjerna and others added 19 commits April 10, 2019 22:44
…lementation

get_mut allows us to abstract over the implementation detail of inner being
optional.
update polonius-engine

This updates polonius-engine to [version 0.7.0](https://github.com/rust-lang/polonius/blob/master/RELEASES.md#v070), which adds a hybrid algorithm that starts off with performing a cheaper, location-insensitive analysis before proceeding with the full analysis.

r? @nikomatsakis
…in-pin-docs, r=RalfJung

Remove [mut] syntax in pin docs

Resolves rust-lang#59832
…nnytm

Make BufWriter use get_mut instead of manipulating inner in Write implementation

`get_mut` allows us to abstract over the implementation detail of inner being optional.
Fix cross-crate visibility of fictive variant constructors

After merging rust-lang#59376 I realized that the code in the decoder wasn't entirely correct - we "decoded" fictive variant constructors with their variant's visibility, which could be public, rather than demoted to `pub(crate)`.

Fictive constructors are not directly usable in expression/patterns, but the effect still can be observed with imports.

r? @davidtwco
…ievink

Add missing backtick to Symbol documentation.
@Centril
Copy link
Contributor Author

Centril commented Apr 14, 2019

@bors r+ p=7

@bors
Copy link
Collaborator

bors commented Apr 14, 2019

📌 Commit c348bb6 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 14, 2019
@bors
Copy link
Collaborator

bors commented Apr 14, 2019

⌛ Testing commit c348bb6 with merge 9cd61f0...

bors added a commit that referenced this pull request Apr 14, 2019
Rollup of 7 pull requests

Successful merges:

 - #59856 (update polonius-engine)
 - #59877 (HirIdify hir::Def)
 - #59896 (Remove duplicated redundant spans)
 - #59900 (Remove [mut] syntax in pin docs)
 - #59906 (Make BufWriter use get_mut instead of manipulating inner in Write implementation)
 - #59936 (Fix cross-crate visibility of fictive variant constructors)
 - #59957 (Add missing backtick to Symbol documentation.)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Apr 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 9cd61f0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 14, 2019
@bors bors merged commit c348bb6 into rust-lang:master Apr 14, 2019
@bors bors mentioned this pull request Apr 14, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #59967!

Tested on commit 9cd61f0.
Direct link to PR: #59967

💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 rls on windows: test-fail → build-fail (cc @nrc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 14, 2019
Tested on commit rust-lang/rust@9cd61f0.
Direct link to PR: <rust-lang/rust#59967>

💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 rls on windows: test-fail → build-fail (cc @nrc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).
@Centril Centril deleted the rollup-bdqq7ux branch April 14, 2019 19:44
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 14, 2019
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants