-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update cargo #60874
Update cargo #60874
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This includes an override to allow this PR to pass since it breaks rls. rls cannot be updated due to #60848. The Cargo team would like to land these changes before the beta branch, and it seems unlikely that the clippy/rls issue will be fixed in time. I have the fixes for rls waiting in the wings (ehuss/rls@f2d51d0), and I'm willing to help fix rls once the clippy issue is resolved. |
cc @Manishearth @Xanewok @nrc re:clippy/rls breakage |
@bors: r+ |
📌 Commit 2811d3220b5120fb8432ea623bb01a89d39c1b91 has been approved by |
@bors: p=1 delegate+ |
✌️ @ehuss can now approve this pull request |
One piece of context for those just joining this conversation: |
@bors p=2 |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
@bors r=alexcrichton |
📌 Commit 6a09cfa has been approved by |
Update cargo 17 commits in 759b6161a328db1d4863139e90875308ecd25a75..c4fcfb725b4be00c72eb9cf30c7d8b095577c280 2019-05-06 20:47:49 +0000 to 2019-05-15 19:48:47 +0000 - tests: registry: revert readonly permission after running tests. (rust-lang/cargo#6947) - Remove Candidate (rust-lang/cargo#6946) - Fix for "Running cargo update without a Cargo.lock ignores arguments" rust-lang/cargo#6872 (rust-lang/cargo#6904) - Fix a minor mistake in the changelog. (rust-lang/cargo#6944) - Give a better error message when crates.io requests time out (rust-lang/cargo#6936) - Re-enable compatibility with readonly CARGO_HOME (rust-lang/cargo#6940) - Fix version of `ignore`. (rust-lang/cargo#6938) - Stabilize offline mode. (rust-lang/cargo#6934) - zsh: Add doc options to include non-public items documentation (rust-lang/cargo#6929) - zsh: Suggest --lib option as binary template now the default (rust-lang/cargo#6926) - Migrate package include/exclude to gitignore patterns. (rust-lang/cargo#6924) - Implement the Cargo half of pipelined compilation (take 2) (rust-lang/cargo#6883) - Always include `Cargo.toml` when packaging. (rust-lang/cargo#6925) - Remove unnecessary calls to masquerade_as_nightly_cargo. (rust-lang/cargo#6923) - download: fix "Downloaded 1 crates" message (crates -> crate) (rust-lang/cargo#6920) - Changed RUST_LOG usage to CARGO_LOG to avoid confusion. (rust-lang/cargo#6918) - crate download: don't print that a crate was the largest download if it was the only download (rust-lang/cargo#6916)
☀️ Test successful - checks-travis, status-appveyor |
Tested on commit rust-lang/rust@7d5aa43. Direct link to PR: <rust-lang/rust#60874> 💔 rls on windows: test-fail → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
Update RLS Includes a fix (rust-lang/rls#1462) for breakage due to Cargo update PR (#60874) r? @Manishearth @oli-obk @ehuss
17 commits in 759b6161a328db1d4863139e90875308ecd25a75..c4fcfb725b4be00c72eb9cf30c7d8b095577c280
2019-05-06 20:47:49 +0000 to 2019-05-15 19:48:47 +0000
ignore
. (Fix version ofignore
. cargo#6938)Cargo.toml
when packaging. (Always includeCargo.toml
when packaging. cargo#6925)