Skip to content

Make cannot move errors more consistent with other borrowck errors #61136

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2019
Merged

Make cannot move errors more consistent with other borrowck errors #61136

merged 5 commits into from
Jun 4, 2019

Conversation

matthewjasper
Copy link
Contributor

  • Note the type of the place being moved in all cases.
  • Note the place being moved from.
  • Simplify the search for overloaded place operators
  • Extend the note for move from overloaded deref apply to all types.
  • Add a note for moves from overloaded index.
  • Special case moves for closure captures.

r? @pnkfelix

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2019
@bors
Copy link
Collaborator

bors commented May 25, 2019

☔ The latest upstream changes (presumably #61150) made this pull request unmergeable. Please resolve the merge conflicts.

@pnkfelix
Copy link
Member

pnkfelix commented Jun 3, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 3, 2019

📌 Commit f7808215211a5a0e2102ea9cf1e299850650c147 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Jun 3, 2019

or rather, r=me once conflicts are resolved.

@pnkfelix pnkfelix added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2019
@matthewjasper
Add is_ref_for_guard method
5cfa70f
@matthewjasper
Add method to note types don't implement Copy
f309f91
@matthewjasper
Improve cannot move errors
f7e86a5 
* Show the place and type being moved
* Give a special error for variables in match guard
* Simplify search for overloaded deref
* Search for overloaded index
@matthewjasper
Use UseSpans in cannot move errors
9336b3d
@matthewjasper
Update tests for changes to cannot move errors
8ffa408
@matthewjasper
Copy link
Contributor Author

@bors r=pnkfelix

@bors
Copy link
Collaborator

bors commented Jun 3, 2019

📌 Commit 8ffa408 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2019
bors added a commit that referenced this pull request Jun 4, 2019
@bors
Auto merge of #61136 - matthewjasper:cannot-move-errors, r=pnkfelix
021a503 
Make cannot move errors more consistent with other borrowck errors

* Note the type of the place being moved in all cases.
* Note the place being moved from.
* Simplify the search for overloaded place operators
* Extend the note for move from overloaded deref apply to all types.
* Add a note for moves from overloaded index.
* Special case moves for closure captures.

r? @pnkfelix
@bors
Copy link
Collaborator

bors commented Jun 4, 2019

⌛ Testing commit 8ffa408 with merge 021a503...

@bors
Copy link
Collaborator

bors commented Jun 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pnkfelix
Pushing 021a503 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 4, 2019
@bors bors merged commit 8ffa408 into rust-lang:master Jun 4, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #61136!

Tested on commit 021a503.
Direct link to PR: #61136

💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 4, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#61136!
f9665e3 
Tested on commit rust-lang/rust@021a503.
Direct link to PR: <rust-lang/rust#61136>

💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
This was referenced Jun 4, 2019
Merged
Merged
@alexcrichton alexcrichton mentioned this pull request Jun 4, 2019
Closed
@matthewjasper matthewjasper deleted the cannot-move-errors branch June 4, 2019 17:30
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 25, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewjasper @bors @pnkfelix @rust-highfive