Remove unneeded feature attr from atomic integers doctests #61453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
A-docs
This comment has been minimized.
This comment has been minimized.
|
@lzutao: 🔑 Insufficient privileges: not in try users |
|
r? @sfackler |
|
Where else is $extra_feature used? It seems like it can be removed entirely from the macro, right? |
|
I was thinking that |
tesuji
force-pushed
the
nouse-featuregate-integer_atomics
branch
2 times, most recently
from
f256ebd to
90d8781
Compare
|
|
tesuji
commented
Jun 2, 2019
|
Oh, okay. |
tesuji
force-pushed
the
nouse-featuregate-integer_atomics
branch
from
90d8781 to
f60b5f1
Compare
|
Ping @sfackler , this PR is ready to review again. |
|
@bors r+ rollup Thanks! |
|
📌 Commit f60b5f1 has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jun 4, 2019
…omics, r=sfackler Remove unneeded feature attr from atomic integers doctests Closes rust-lang#61448 r? @Centril
bors
added a commit
that referenced
this pull request
Jun 4, 2019
Rollup of 5 pull requests Successful merges: - #61069 (Make MIR drop terminators borrow the dropped location) - #61453 (Remove unneeded feature attr from atomic integers doctests) - #61488 (Fix NLL typeck ICEs) - #61500 (Fix regression 61475) - #61523 (Hide gen_future API from documentation) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61448
r? @Centril