Add a few trait impls for AccessError #61491

ghost · 2019-06-03T16:04:06Z

No description provided.

rust-highfive · 2019-06-03T16:04:15Z

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-06-03T16:04:17Z

⚠️ Warning ⚠️

These commits modify submodules.

ghost · 2019-06-03T16:21:26Z

There were some accidental submodule updates, but now they seem to be removed. Sorry for the noise!

bors · 2019-06-20T05:49:42Z

☔ The latest upstream changes (presumably #60341) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum · 2019-07-09T20:52:19Z

src/libstd/thread/local.rs

@@ -207,6 +209,8 @@ impl fmt::Display for AccessError {
    }
 }

+impl Error for AccessError {}


We'll probably want a #[stable... attribute on this even though it does nothing today :)

Mark-Simulacrum · 2019-07-09T20:52:42Z

r? @dtolnay

dtolnay · 2019-07-12T03:47:37Z

@rust-lang/libs -- this PR adds impls of Clone, Copy, Eq, PartialEq, and Error for std::thread::AccessError, which is the error returned by the try_with method on thread locals. See Utf8Error, CharTryFromError, TryFromIntError, fmt::Error, RecvTimeoutError, RecvError, TryRecvError as examples of existing error types having all of these impls.

  impl<T: 'static> LocalKey<T> {
      pub fn try_with<F, R>(&'static self, f: F) -> Result<R, AccessError>
      where
          F: FnOnce(&T) -> R;
  }

  pub struct AccessError { _private: () }

+ impl Clone for AccessError {...}
+ impl Copy for AccessError {...}
+ impl Eq for AccessError {...}
+ impl PartialEq for AccessError {...}
+ impl std::error::Error for AccessError {...}

@rfcbot fcp merge

rfcbot · 2019-07-12T03:49:03Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2019-07-24T17:41:55Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2019-08-03T17:59:27Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

alexcrichton · 2019-08-05T15:11:00Z

@bors: r=dtolnay

bors · 2019-08-05T15:11:01Z

📌 Commit d2c9c12 has been approved by dtolnay

bors · 2019-08-05T15:30:52Z

⌛ Testing commit d2c9c12 with merge f6ecdc2...

Add a few trait impls for AccessError

bors · 2019-08-05T19:06:44Z

☀️ Test successful - checks-azure
Approved by: dtolnay
Pushing f6ecdc2 to master...

Pkgsrc changes: * Adapt to the move of the implementation of random numbers. * Remove patch which is no longer relevant (Signals.inc) * Cross-build currently fails due to the still unresolved rust-lang/rust#62558, so bootstrap kits for 1.38.0 have to be built natively, and will follow shortly. * Bump bootstrap requirements to 1.37.0 except for armv7-unknown-netbsd-eabihf which I've neither managed to cross-build nor build natively. Upstream changes: Version 1.38.0 (2019-09-26) ========================== Language -------- - [The `#[global_allocator]` attribute can now be used in submodules.][62735] - [The `#[deprecated]` attribute can now be used on macros.][62042] Compiler -------- - [Added pipelined compilation support to `rustc`.][62766] This will improve compilation times in some cases. For further information please refer to the [_"Evaluating pipelined rustc compilation"_][pipeline-internals] thread. - [Added tier 3\* support for the `aarch64-uwp-windows-msvc`, `i686-uwp-windows-gnu`, `i686-uwp-windows-msvc`, `x86_64-uwp-windows-gnu`, and `x86_64-uwp-windows-msvc` targets.][60260] - [Added tier 3 support for the `armv7-unknown-linux-gnueabi` and `armv7-unknown-linux-musleabi` targets.][63107] - [Added tier 3 support for the `hexagon-unknown-linux-musl` target.][62814] - [Added tier 3 support for the `riscv32i-unknown-none-elf` target.][62784] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`ascii::EscapeDefault` now implements `Clone` and `Display`.][63421] - [Derive macros for prelude traits (e.g. `Clone`, `Debug`, `Hash`) are now available at the same path as the trait.][63056] (e.g. The `Clone` derive macro is available at `std::clone::Clone`). This also makes all built-in macros available in `std`/`core` root. e.g. `std::include_bytes!`. - [`str::Chars` now implements `Debug`.][63000] - [`slice::{concat, connect, join}` now accepts `&[T]` in addition to `&T`.][62528] - [`*const T` and `*mut T` now implement `marker::Unpin`.][62583] - [`Arc<[T]>` and `Rc<[T]>` now implement `FromIterator<T>`.][61953] - [Added euclidean remainder and division operations (`div_euclid`, `rem_euclid`) to all numeric primitives.][61884] Additionally `checked`, `overflowing`, and `wrapping` versions are available for all integer primitives. - [`thread::AccessError` now implements `Clone`, `Copy`, `Eq`, `Error`, and `PartialEq`.][61491] - [`iter::{StepBy, Peekable, Take}` now implement `DoubleEndedIterator`.][61457] Stabilized APIs --------------- - [`<*const T>::cast`] - [`<*mut T>::cast`] - [`Duration::as_secs_f32`] - [`Duration::as_secs_f64`] - [`Duration::div_duration_f32`] - [`Duration::div_duration_f64`] - [`Duration::div_f32`] - [`Duration::div_f64`] - [`Duration::from_secs_f32`] - [`Duration::from_secs_f64`] - [`Duration::mul_f32`] - [`Duration::mul_f64`] - [`any::type_name`] Cargo ----- - [Added pipelined compilation support to `cargo`.][cargo/7143] - [You can now pass the `--features` option multiple times to enable multiple features.][cargo/7084] Misc ---- - [`rustc` will now warn about some incorrect uses of `mem::{uninitialized, zeroed}` that are known to cause undefined behaviour.][63346] Compatibility Notes ------------------- - Unfortunately the [`x86_64-unknown-uefi` platform can not be built][62785] with rustc 1.39.0. - The [`armv7-unknown-linux-gnueabihf` platform is also known to have issues][62896] for certain crates such as libc. [60260]: rust-lang/rust#60260 [61457]: rust-lang/rust#61457 [61491]: rust-lang/rust#61491 [61884]: rust-lang/rust#61884 [61953]: rust-lang/rust#61953 [62042]: rust-lang/rust#62042 [62528]: rust-lang/rust#62528 [62583]: rust-lang/rust#62583 [62735]: rust-lang/rust#62735 [62766]: rust-lang/rust#62766 [62784]: rust-lang/rust#62784 [62785]: rust-lang/rust#62785 [62814]: rust-lang/rust#62814 [62896]: rust-lang/rust#62896 [63000]: rust-lang/rust#63000 [63056]: rust-lang/rust#63056 [63107]: rust-lang/rust#63107 [63346]: rust-lang/rust#63346 [63421]: rust-lang/rust#63421 [cargo/7084]: rust-lang/cargo#7084 [cargo/7143]: rust-lang/cargo#7143 [`<*const T>::cast`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.cast [`<*mut T>::cast`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.cast [`Duration::as_secs_f32`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_secs_f32 [`Duration::as_secs_f64`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_secs_f64 [`Duration::div_duration_f32`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.div_duration_f32 [`Duration::div_duration_f64`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.div_duration_f64 [`Duration::div_f32`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.div_f32 [`Duration::div_f64`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.div_f64 [`Duration::from_secs_f32`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.from_secs_f32 [`Duration::from_secs_f64`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.from_secs_f64 [`Duration::mul_f32`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.mul_f32 [`Duration::mul_f64`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.mul_f64 [`any::type_name`]: https://doc.rust-lang.org/std/any/fn.type_name.html [forge-platform-support]: https://forge.rust-lang.org/platform-support.html [pipeline-internals]: https://internals.rust-lang.org/t/evaluating-pipelined-rustc-compilation/10199

rust-highfive assigned steveklabnik Jun 3, 2019

This comment has been minimized.

# to view

jonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 10, 2019

Add a few trait impls for AccessError

d6c3196

Mark-Simulacrum reviewed Jul 9, 2019

View reviewed changes

Mark-Simulacrum added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Jul 9, 2019

Mark-Simulacrum unassigned steveklabnik Jul 9, 2019

rust-highfive assigned dtolnay Jul 9, 2019

Mark-Simulacrum added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2019

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 12, 2019

Centril added this to the 1.38 milestone Jul 21, 2019

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 21, 2019

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 24, 2019

Centril added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jul 30, 2019

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 3, 2019

Add #[stable] to Error impl

d2c9c12

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 5, 2019

bors added a commit that referenced this pull request Aug 5, 2019

Auto merge of #61491 - stjepang:impls-for-accesserror, r=dtolnay

f6ecdc2

Add a few trait impls for AccessError

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2019

bors merged commit d2c9c12 into rust-lang:master Aug 5, 2019

ghost deleted the impls-for-accesserror branch August 5, 2019 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a few trait impls for AccessError #61491

Add a few trait impls for AccessError #61491

Uh oh!

ghost commented Jun 3, 2019

Uh oh!

rust-highfive commented Jun 3, 2019

Uh oh!

rust-highfive commented Jun 3, 2019

Uh oh!

This comment has been minimized.

ghost commented Jun 3, 2019 •

edited by ghost

Loading

Uh oh!

bors commented Jun 20, 2019

Uh oh!

Mark-Simulacrum Jul 9, 2019

Uh oh!

Mark-Simulacrum commented Jul 9, 2019

Uh oh!

dtolnay commented Jul 12, 2019

Uh oh!

rfcbot commented Jul 12, 2019 •

edited by Kimundi

Loading

Uh oh!

rfcbot commented Jul 24, 2019

Uh oh!

rfcbot commented Aug 3, 2019

Uh oh!

alexcrichton commented Aug 5, 2019

Uh oh!

bors commented Aug 5, 2019

Uh oh!

bors commented Aug 5, 2019

Uh oh!

bors commented Aug 5, 2019

Uh oh!

Uh oh!

Add a few trait impls for AccessError #61491

Add a few trait impls for AccessError #61491

Uh oh!

Conversation

ghost commented Jun 3, 2019

Uh oh!

rust-highfive commented Jun 3, 2019

Uh oh!

rust-highfive commented Jun 3, 2019

Uh oh!

This comment has been minimized.

ghost commented Jun 3, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jun 20, 2019

Uh oh!

Mark-Simulacrum Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum commented Jul 9, 2019

Uh oh!

dtolnay commented Jul 12, 2019

Uh oh!

rfcbot commented Jul 12, 2019 • edited by Kimundi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Jul 24, 2019

Uh oh!

rfcbot commented Aug 3, 2019

Uh oh!

alexcrichton commented Aug 5, 2019

Uh oh!

bors commented Aug 5, 2019

Uh oh!

bors commented Aug 5, 2019

Uh oh!

bors commented Aug 5, 2019

Uh oh!

Uh oh!

ghost commented Jun 3, 2019 •

edited by ghost

Loading

rfcbot commented Jul 12, 2019 •

edited by Kimundi

Loading