-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update stdsimd #61540
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update stdsimd #61540
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
r=me, but looks like some new features may now be required? |
TBH, I don't have an idea what does these failures mean. Why these features are required? Is it because stdsimd wasn't updated for a while? What can I do to fix them? |
I believe they're basically new features being used by stdsimd so |
@alexcrichton it seems that worked! |
@bors: r+ |
📌 Commit d8b2e85 has been approved by |
⌛ Testing commit d8b2e85 with merge eb8f9c12a9229a927218e5e6e369db2bbe124e7d... |
…hton Update stdsimd Ref rust-lang#61119, for stabilization of wasm32 `unreachable`
@bors retry |
⌛ Testing commit d8b2e85 with merge 1a1dfa463a311f78a4979d497f0dbe96fdc45a95... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
cc @gnzlbg, this looks like a compile error in stdsimd? |
cc @lu-zero, instead of |
…xcrichton Increases heap size available during testing for SGX PR [61540](rust-lang#61540) causes at least one test to fail when run for the SGX platform due to lack of memory. This PR increases the heapsize available during tests, which is a good thing regardless of the status of that PR.
@bors r- |
stdsimd does not build due to #61959 , but that has been merged now so the
next nightly “should” work.
…On Fri 21. Jun 2019 at 21:17, Pietro Albini ***@***.***> wrote:
@bors <https://github.com/bors> r-
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61540?email_source=notifications&email_token=AAG43JXV6WBLVJCNDYLAY43P3USLJA5CNFSM4HTVHVI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJLJYY#issuecomment-504542435>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG43JWMMPIUCUEL24T7VYTP3USLJANCNFSM4HTVHVIQ>
.
|
@gnzlbg: 🔑 Insufficient privileges: Not in reviewers |
Should we retry bors then? |
@pepyakin rust-lang/stdarch#768 needs to be merged first but it couldn't have been tested because of broken nightly. |
stdsimd is broken upstream, so that needs to be fixed first; otherwise one would be updating stdsimd in rust-lang/rust to a broken version |
@pepyakin this should be unblocked now. Can you try updating this PR to use |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@pepyakin the repo was indeed renamed, so this will need to move the submodule to Let me know if you feel up to it. Otherwise I can do this later today. |
It would be great to actually get your hand here! |
Ping from triage @pepyakin any updates on this? |
This can be closed, an update with these changes already happened. |
Ref #61119, for stabilization of wasm32
unreachable