-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Remove rustc_mir dependency from rustc_borrowck #61590
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove rustc_mir dependency from rustc_borrowck #61590
Conversation
Some changes occurred in diagnostic error codes |
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
e847a0f
to
0100cc2
Compare
I don't think I'll have time to review something this large very soon, so I'm going to reassign. r? @pnkfelix |
☔ The latest upstream changes (presumably #61735) made this pull request unmergeable. Please resolve the merge conflicts. |
0100cc2
to
6b30007
Compare
☔ The latest upstream changes (presumably #60730) made this pull request unmergeable. Please resolve the merge conflicts. |
6b30007
to
9f56232
Compare
☔ The latest upstream changes (presumably #61915) made this pull request unmergeable. Please resolve the merge conflicts. |
9f56232
to
e71878d
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #62041) made this pull request unmergeable. Please resolve the merge conflicts. |
e71878d
to
bfccc1e
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bfccc1e
to
e71dabf
Compare
☔ The latest upstream changes (presumably #62119) made this pull request unmergeable. Please resolve the merge conflicts. |
e71dabf
to
49eff23
Compare
Sorry it’s taken me so long to see this The diff for at least one file (borrowck/mod.rs) seems like github did not see the initial move due to the crate rename. Could we save the rename for a different PR? Or at least a separate commit in the series? |
49eff23
to
ff7b500
Compare
This is now split into two commits |
☔ The latest upstream changes (presumably #62355) made this pull request unmergeable. Please resolve the merge conflicts. |
ff7b500
to
965b06d
Compare
☔ The latest upstream changes (presumably #59800) made this pull request unmergeable. Please resolve the merge conflicts. |
r=me once merge conflicts are resolved. Sorry for taking so long to get back around to this. Update: as a mea culpa for taking so long, I went ahead and rebased the PR, double-checked that it built locally, and force-pushed up to @matthewjasper 's branch, in the hopes of r+'ing this myself now. |
965b06d
to
151cf12
Compare
@bors r+ rollup |
📌 Commit 151cf12677cee27e5b880473cd023dc66e08b7ca has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r- |
151cf12
to
6f5bb5b
Compare
@bors r=pnkfelix |
📌 Commit 6f5bb5b0c30f27df16949448ae08d20e098336b6 has been approved by |
6f5bb5b
to
34ddc70
Compare
@bors r=pnkfelix |
📌 Commit 34ddc70 has been approved by |
@bors rollup=never |
@bors p=30 |
…r=pnkfelix Remove rustc_mir dependency from rustc_borrowck Also renames `rustc_borrowck` to `rustc_ast_borrowck` and removes all error reporting from it. cc #59193
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
Also renames
rustc_borrowck
torustc_ast_borrowck
and removes all error reporting from it.cc #59193