Skip to content

Minimize use of #![feature(custom_attribute)] #61660

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Jun 9, 2019

Conversation

petrochenkov
Copy link
Contributor

Some preparations before resurrecting #57921.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2019
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? @Centril

r=me with or without changes for the notes below.

@Centril Centril assigned Centril and unassigned eddyb Jun 8, 2019
@petrochenkov
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Collaborator

bors commented Jun 8, 2019

📌 Commit ee189ae has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 8, 2019
Minimize use of `#![feature(custom_attribute)]`

Some preparations before resurrecting rust-lang#57921.
bors added a commit that referenced this pull request Jun 8, 2019
Rollup of 6 pull requests

Successful merges:

 - #61646 (Remove useless allocations in macro_rules follow logic.)
 - #61658 (remove useless ident() functions in const tests)
 - #61660 (Minimize use of `#![feature(custom_attribute)]`)
 - #61666 (Add test for trait ICE)
 - #61669 ( syntax: Remove `Deref` impl from `Token`)
 - #61670 (Update RLS)

Failed merges:

r? @ghost
@bors bors merged commit ee189ae into rust-lang:master Jun 9, 2019
@petrochenkov petrochenkov deleted the nocusta branch June 9, 2019 07:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants