Skip to content

move stray run-pass const tests into const/ folder #61701

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

move stray run-pass const tests into const/ folder #61701

merged 1 commit into from
Jun 19, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 9, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2019
@Centril
Copy link
Contributor

Centril commented Jun 9, 2019

Can we move these to ui/ ?

@petrochenkov
Copy link
Contributor

@Centril
As I mentioned previously, run-pass threads should not be moved into the ui directory unless some way to run them separately is implemented (#54047).

@Centril
Copy link
Contributor

Centril commented Jun 10, 2019 •
edited
Loading

@petrochenkov All new run-pass tests are currently being added in ui/ in any case. I also disagree with the reasons you provided in that issue. Developer UX is not as important than having a well organized test suite (we don't -- the current test suite is horribly disorganized) for specification purposes. However, I suppose I will have to implement the idea by @nikomatsakis to filter tests by mode... (I agree entirely with sentiments expressed in #54047 (comment))

@petrochenkov
Copy link
Contributor

petrochenkov commented Jun 10, 2019 •
edited
Loading

@Centril

Developer UX is not as important than having a well organized test suite

I disagree, it's a real practical issue that interferes with daily work.

Having feature directories my_feature in two directories (ui and run-pass) in not significantly worse that in one directory.

All new run-pass tests are currently being added in ui/ in any case.

Reviews should prevent that (until the separate running is supported).

@RalfJung
Copy link
Member Author

RalfJung commented Jun 10, 2019 •
edited
Loading

I'd say moving run-pass tests to ui is a different issue and orthogonal to what this PR is trying to achieve. The last time all ui tests were moved to run-pass, that was quickly reverted; it is not the place of this PR to (somewhat sneakily in a "slowly boiling the frog" manner) revert part of that revert.

@RalfJung
Copy link
Member Author

@rust-lang/compiler (I hope this is the right team) still waiting for a review. :)

@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 18, 2019

📌 Commit 5fa8b52 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 18, 2019
@Centril
Rollup merge of rust-lang#61701 - RalfJung:const-tests, r=cramertj
26880f6 
move stray run-pass const tests into const/ folder

r? @oli-obk
@Centril Centril mentioned this pull request Jun 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 18, 2019
@Centril
Rollup merge of rust-lang#61701 - RalfJung:const-tests, r=cramertj
65da792 
move stray run-pass const tests into const/ folder

r? @oli-obk
@Centril Centril mentioned this pull request Jun 18, 2019
Merged
bors added a commit that referenced this pull request Jun 19, 2019
@bors
Auto merge of #61945 - Centril:rollup-xdqo2mn, r=Centril
1a47728 
Rollup of 11 pull requests

Successful merges:

 - #61505 (Only show methods that appear in `impl` blocks in the Implementors sections of trait doc pages)
 - #61701 (move stray run-pass const tests into const/ folder)
 - #61748 (Tweak transparent enums and unions diagnostic spans)
 - #61802 (Make MaybeUninit #[repr(transparent)])
 - #61839 (ci: Add a script for generating CPU usage graphs)
 - #61842 (Remove unnecessary lift calls)
 - #61843 (Turn down the myriad-closures test)
 - #61896 (rustc_typeck: correctly compute `Substs` for `Res::SelfCtor`.)
 - #61898 (syntax: Factor out common fields from `SyntaxExtension` variants)
 - #61938 (create an issue for miri even in status test-fail)
 - #61941 (Preserve generator and yield source for error messages)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Jun 19, 2019
@bors
Auto merge of #61945 - Centril:rollup-xdqo2mn, r=Centril
93e63e4 
Rollup of 11 pull requests

Successful merges:

 - #61505 (Only show methods that appear in `impl` blocks in the Implementors sections of trait doc pages)
 - #61701 (move stray run-pass const tests into const/ folder)
 - #61748 (Tweak transparent enums and unions diagnostic spans)
 - #61802 (Make MaybeUninit #[repr(transparent)])
 - #61839 (ci: Add a script for generating CPU usage graphs)
 - #61842 (Remove unnecessary lift calls)
 - #61843 (Turn down the myriad-closures test)
 - #61896 (rustc_typeck: correctly compute `Substs` for `Res::SelfCtor`.)
 - #61898 (syntax: Factor out common fields from `SyntaxExtension` variants)
 - #61938 (create an issue for miri even in status test-fail)
 - #61941 (Preserve generator and yield source for error messages)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Jun 19, 2019
@bors
Auto merge of #61945 - Centril:rollup-xdqo2mn, r=Centril
a6cbf2d 
Rollup of 11 pull requests

Successful merges:

 - #61505 (Only show methods that appear in `impl` blocks in the Implementors sections of trait doc pages)
 - #61701 (move stray run-pass const tests into const/ folder)
 - #61748 (Tweak transparent enums and unions diagnostic spans)
 - #61802 (Make MaybeUninit #[repr(transparent)])
 - #61839 (ci: Add a script for generating CPU usage graphs)
 - #61842 (Remove unnecessary lift calls)
 - #61843 (Turn down the myriad-closures test)
 - #61896 (rustc_typeck: correctly compute `Substs` for `Res::SelfCtor`.)
 - #61898 (syntax: Factor out common fields from `SyntaxExtension` variants)
 - #61938 (create an issue for miri even in status test-fail)
 - #61941 (Preserve generator and yield source for error messages)

Failed merges:

r? @ghost
@bors bors merged commit 5fa8b52 into rust-lang:master Jun 19, 2019
@RalfJung RalfJung deleted the const-tests branch June 21, 2019 07:03
@RalfJung RalfJung mentioned this pull request Jun 29, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @Centril @petrochenkov @cramertj @bors @oli-obk @rust-highfive