-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Separate unit tests #61739
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Separate unit tests #61739
Conversation
@chansuke r=me once the rebase is done and CI is green (squashing is usually at the discretion of the author). r? @petrochenkov |
@bors p=10 More conflict prone than you think. |
2498791
to
c13d852
Compare
@petrochenkov Sorry for the late reply and thanks for the information (and about |
6762543
to
7c6e5e7
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@chansuke General hint for the following PRs - instead of foo.rs
=>
foo/mod.rs
foo/tests.rs you can use foo.rs
=>
foo.rs
foo/tests.rs This way you can avoid most of conflicts and won't have to rebase all the time. |
201d879
to
5a9643c
Compare
@bors r+ |
📌 Commit 5a9643c has been approved by |
Separate unit tests I'm working on #61097. About half of the modules are done but dozens of modules are still remaining. I will rebase and squash the commits later.
☀️ Test successful - checks-travis, status-appveyor |
Tested on commit rust-lang/rust@37b6a5e. Direct link to PR: <rust-lang/rust#61739> 🎉 rls on windows: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
I'm working on #61097.
About half of the modules are done but dozens of modules are still remaining. I will rebase and squash the commits later.