Use a more efficient iteration order for backward dataflow #62063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @pnkfelix |
ecstatic-morse
changed the title
|
@bors try |
|
⌛ Trying commit 8e31907037a8e96b0b0699402d6251e6629504e1 with merge 64420abf98e4822f5299cc07aabf03f9ca5465d0... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
ecstatic-morse
force-pushed
the
dataflow-backward-order
branch
from
fd4ad92 to
a6eb19f
Compare
|
@bors try |
|
⌛ Trying commit a6eb19f1bd3992e04b8ae2bb55360b522b6935e4 with merge 062f8b868d47236fa65183c8fedd5de70cbc8eb9... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-author
ecstatic-morse
force-pushed
the
dataflow-backward-order
branch
from
a6eb19f to
4773e55
Compare
|
I'm sorry, I forgot to remove the debug assertion from this one. Can someone trigger another build? |
|
@bors try |
|
⌛ Trying commit 4773e5519b989edf4639929feae343ccb43d62e0 with merge 56b7200c037e2a958f7d907e778b87e58beb7079... |
|
☀️ Try build successful - checks-travis |
|
@rust-timer build 56b7200c037e2a958f7d907e778b87e58beb7079 |
|
Success: Queued 56b7200c037e2a958f7d907e778b87e58beb7079 with parent a96ba96, comparison URL. |
|
Finished benchmarking try commit 56b7200c037e2a958f7d907e778b87e58beb7079, comparison URL. |
|
This does substantially reduce the number of iterations, it's just that backward dataflow is only used for generators at the moment (I should have checked this before I requested a perf run, although #62062 needed one anyway). Here are the results from running the tests in Before: After: |
|
This seems fine to me. Its currently marked waiting-on-author, but I don't really have much to add as a reviewer. |
This applies the same basic principle as rust-lang#62062 to the reverse dataflow analysis used to compute liveness information. It is functionally equivalent, except that post-order is used instead of reverse post-order. Some `mir::Body`s contain basic blocks which are not reachable from the `START_BLOCK`. We need to add them to the work queue as well to preserve the original semantics.
ecstatic-morse
force-pushed
the
dataflow-backward-order
branch
from
4773e55 to
e2479e2
Compare
|
@bors r+ |
|
📌 Commit e2479e2 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 30, 2019
…der, r=nagisa Use a more efficient iteration order for backward dataflow This applies the same basic principle as rust-lang#62062 to the reverse dataflow analysis used to compute liveness information. It is functionally equivalent, except that post-order is used instead of reverse post-order. In the long-term, `BitDenotation` should probably be extended to support both forward and backward dataflow, but there's some more work needed to get to that point.
bors
added a commit
that referenced
this pull request
Jul 1, 2019
Rollup of 8 pull requests Successful merges: - #62062 (Use a more efficient iteration order for forward dataflow) - #62063 (Use a more efficient iteration order for backward dataflow) - #62224 (rustdoc: remove unused derives and variants) - #62228 (Extend the #[must_use] lint to boxed types) - #62235 (Extend the `#[must_use]` lint to arrays) - #62239 (Fix a typo) - #62241 (Always parse 'async unsafe fn' + properly ban in 2015) - #62248 (before_exec actually will only get deprecated with 1.37) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same basic principle as #62062 to the reverse dataflow analysis used to compute liveness information. It is functionally equivalent, except that post-order is used instead of reverse post-order.
In the long-term,
BitDenotationshould probably be extended to support both forward and backward dataflow, but there's some more work needed to get to that point.