Skip to content

Feature gate rustc attributes harder #62133

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2019
Merged

Feature gate rustc attributes harder #62133

merged 2 commits into from
Jul 5, 2019

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jun 25, 2019 •
edited
Loading

Fixes #62116

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2019
@petrochenkov
Copy link
Contributor Author

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@petrochenkov
Copy link
Contributor Author

Damn.
@bors try

@bors
Copy link
Collaborator

bors commented Jun 25, 2019

⌛ Trying commit 7fbb936 with merge 8ec8125...

bors added a commit that referenced this pull request Jun 25, 2019
@bors
Auto merge of #62133 - petrochenkov:norustc, r=<try>
8ec8125 
Feature gate `rustc` attributes harder

cc #62116
@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2019
@bors
Copy link
Collaborator

bors commented Jun 26, 2019

☀️ Try build successful - checks-travis
Build commit: 8ec8125

@petrochenkov
Copy link
Contributor Author

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-62133 created and queued.
🤖 Automatically detected try build 8ec8125
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-62133 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-62133 is completed!
📊 1 regressed and 0 fixed (66894 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 29, 2019
@petrochenkov
Copy link
Contributor Author

The single regression is #[rustc::attr(...)] in tests in remain, and #[rustc::foo] attributes are certainly something we want to reserve.

Ok, I think I'll apply a0d792c to this PR (requires rustc to register its own attributes instead of using feature(custom_attribute)-style fallback from unresolved), and it's good to go.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2019
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2019
@petrochenkov
Copy link
Contributor Author

Updated.

@petrochenkov petrochenkov mentioned this pull request Jul 1, 2019
Merged
@petrochenkov
Copy link
Contributor Author

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned cramertj Jul 1, 2019
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2019
@Manishearth
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
62b38c1 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Manishearth Manishearth mentioned this pull request Jul 2, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 3, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
351442b 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 3, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 4, 2019
@Centril
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
0668f38 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Centril Centril mentioned this pull request Jul 4, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
b5246fd 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 4, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
2a374b0 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
de03018 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
51454fd 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
0224532 
Feature gate `rustc` attributes harder

Fixes rust-lang#62116
@Centril Centril mentioned this pull request Jul 5, 2019
Merged
bors added a commit that referenced this pull request Jul 5, 2019
@bors
Auto merge of #62419 - Centril:rollup-82umycq, r=Centril
481068a 
Rollup of 13 pull requests

Successful merges:

 - #61545 (Implement another internal lints)
 - #62110 (Improve -Ztime-passes)
 - #62133 (Feature gate `rustc` attributes harder)
 - #62158 (Add MemoryExtra in InterpretCx constructor params)
 - #62168 (The (almost) culmination of HirIdification)
 - #62193 (Create async version of the dynamic-drop test)
 - #62369 (Remove `compile-pass` from compiletest)
 - #62380 (rustc_target: avoid negative register counts in the SysV x86_64 ABI.)
 - #62381 (Fix a typo in Write::write_vectored docs)
 - #62390 (Update README.md)
 - #62396 (remove Scalar::is_null_ptr)
 - #62406 (Lint on invalid values passed to x.py --warnings)
 - #62414 (Remove last use of mem::uninitialized in SGX)

Failed merges:

r? @ghost
@bors bors merged commit e4e7eb2 into rust-lang:master Jul 5, 2019
@dtolnay dtolnay mentioned this pull request Jul 7, 2019
Closed
@petrochenkov petrochenkov mentioned this pull request Jul 8, 2019
Open
@petrochenkov petrochenkov deleted the norustc branch July 8, 2019 13:33
This was referenced Aug 24, 2019
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attributes starting with rustc_ are supposed to be gated, but they are not always gated
6 participants
@petrochenkov @rust-highfive @craterbot @bors @eddyb @cramertj