Skip to content

SIMD for Rust, take 2 #6214

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
May 8, 2013
Merged

SIMD for Rust, take 2 #6214

merged 7 commits into from
May 8, 2013

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented May 3, 2013

At the moment this only includes type checking and there is no code generation support yet. I wanted to get the design reviewed first.

From discussion with @graydon at #5841, re-implemented as #[simd] attribute on structs.

Progressing towards #3499.

@sanxiyn
Copy link
Member Author

sanxiyn commented May 3, 2013

One issue I found is that it is no longer possible to decide whether type is a SIMD vector solely from type. You also need type context. This means, for example, pub fn type_is_immediate(ty: t) -> bool signature needs to change.

Or do you have a better idea?

@graydon
Copy link
Contributor

graydon commented May 7, 2013

This looks pretty good to me. Thanks for the patient revisions.

Since I am less aware of what servo will need / want in this area (and haven't written SIMD code in years) perhaps @pcwalton should also take a look to confirm?

@sanxiyn
Copy link
Member Author

sanxiyn commented May 7, 2013

Rebased.

@brson
Copy link
Contributor

brson commented May 8, 2013

Can we put the library parts in core::unstable? This is an experimental feature.

@yichoi
Copy link
Contributor

yichoi commented May 8, 2013

sounds reasonable to locate core::unstable

@sanxiyn
Copy link
Member Author

sanxiyn commented May 8, 2013

Moved.

@nikomatsakis
Copy link
Contributor

@sanxiyn I read over the patch. It looks pretty good to me so far.

bors added a commit that referenced this pull request May 8, 2013
At the moment this only includes type checking and there is no code generation support yet. I wanted to get the design reviewed first.

From discussion with @graydon at #5841, re-implemented as `#[simd]` attribute on structs.

Progressing towards #3499.
@bors bors closed this May 8, 2013
@bors bors merged commit eb5fa06 into rust-lang:incoming May 8, 2013
@bstrie bstrie mentioned this pull request Jun 25, 2013
bors added a commit that referenced this pull request Jul 12, 2013
Fix #3499.

This is the other half of #5841 that was left out when I revised it to #6214.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants