rename InterpretCx -> InterpCx #62173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's more consistent with InterpResult and InterpError.
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit fc918a3 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
@bors rollup=never (breaks Miri) |
|
Looks very much like the Miri update will land first, so let's avoid wasting CI time. @bors r- |
bors
added
S-waiting-on-author
|
It's just 4h until it's Wednesday UTC, I feel confident this will not land fast enough to cause problems and I want to stop having to remember.^^ @bors r=oli-obk |
|
📌 Commit fc918a3 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup- |
|
@bors rollup |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
rename InterpretCx -> InterpCx That's more consistent with InterpResult and InterpError. r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
rename InterpretCx -> InterpCx That's more consistent with InterpResult and InterpError. r? @oli-obk
bors
added a commit
that referenced
this pull request
Jul 3, 2019
Rollup of 17 pull requests Successful merges: - #62039 (Remove needless lifetimes (rustc)) - #62153 (Update the `rust-installer` submodule) - #62173 (rename InterpretCx -> InterpCx) - #62240 (wfcheck: resolve the type-vars in `AdtField` types) - #62249 (Use mem::take instead of mem::replace with default) - #62252 (Update mem::replace example to not be identical to mem::take) - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser) - #62268 (Clean up inherent_impls) - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind) - #62295 (miri realloc: do not require giving old size+align) - #62297 (refactor check_for_substitution) - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.) - #62317 (Migrate `compile-pass` annotations to `build-pass`) - #62337 (Fix bucket in CPU usage script) - #62344 (simplify Option::get_or_insert) - #62346 (enable a few more tests in Miri and update the comment for others) - #62351 (remove bogus example from drop_in_place) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
rename InterpretCx -> InterpCx That's more consistent with InterpResult and InterpError. r? @oli-obk
bors
added a commit
that referenced
this pull request
Jul 3, 2019
Rollup of 16 pull requests Successful merges: - #62039 (Remove needless lifetimes (rustc)) - #62173 (rename InterpretCx -> InterpCx) - #62240 (wfcheck: resolve the type-vars in `AdtField` types) - #62249 (Use mem::take instead of mem::replace with default) - #62252 (Update mem::replace example to not be identical to mem::take) - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser) - #62268 (Clean up inherent_impls) - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind) - #62295 (miri realloc: do not require giving old size+align) - #62297 (refactor check_for_substitution) - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.) - #62317 (Migrate `compile-pass` annotations to `build-pass`) - #62337 (Fix bucket in CPU usage script) - #62344 (simplify Option::get_or_insert) - #62346 (enable a few more tests in Miri and update the comment for others) - #62351 (remove bogus example from drop_in_place) Failed merges: r? @ghost
|
miri still broken?! I see it's fixed in miri rust-lang/miri@1729965 now if only I can tell rust to use a newer commit hmm... ok this worked: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's more consistent with InterpResult and InterpError.
r? @oli-obk