Skip to content

Revert "implicit Option-returning doctests" #62267

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

GuillaumeGomez
Copy link
Member

Reverts #61279 as discussed in #61360.

cc @Centril

@GuillaumeGomez GuillaumeGomez force-pushed the revert-implicit-option-return branch 2 times, most recently from a4c36b3 to 6744e0e Compare July 1, 2019 12:54
@Centril
Copy link
Contributor

Centril commented Jul 1, 2019

r? @Centril

Normally I wouldn't review rustdoc PRs but since this is a clean revert...

@bors r+ p=30 -- we want to land this before master -> beta promotion to avoid a backport.

@bors
Copy link
Collaborator

bors commented Jul 1, 2019

📌 Commit 6744e0e0fc37b08511f0c770e2537e80f2abca41 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned ollie27 Jul 1, 2019
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 1, 2019
@GuillaumeGomez GuillaumeGomez force-pushed the revert-implicit-option-return branch from 6744e0e to a683bb1 Compare July 1, 2019 14:42
@Centril
Copy link
Contributor

Centril commented Jul 1, 2019

@bors r+ p=30

@bors
Copy link
Collaborator

bors commented Jul 1, 2019

📌 Commit a683bb1 has been approved by Centril

@bors
Copy link
Collaborator

bors commented Jul 1, 2019

⌛ Testing commit a683bb1 with merge 17e62f7...

bors added a commit that referenced this pull request Jul 1, 2019
…r=Centril

Revert "implicit `Option`-returning doctests"

Reverts #61279 as discussed in #61360.

cc @Centril
@bors
Copy link
Collaborator

bors commented Jul 1, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: Centril
Pushing 17e62f7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 1, 2019
@bors bors merged commit a683bb1 into rust-lang:master Jul 1, 2019
@GuillaumeGomez GuillaumeGomez deleted the revert-implicit-option-return branch July 2, 2019 08:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants