-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Delay bug to resolve HRTB ICE #62523
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Delay bug to resolve HRTB ICE #62523
Conversation
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
Note: I didn't dissect the original test case very carefully, in the sense that I am assuming that the compiler errors are not lying to us, this code should be rejected (just not with an ICE), and there is indeed a type mismatch of the kind it describes. It would be nice for someone to go through and try to reduce the test case further. (But in a meaningful fashion; don't just refold all my Unit1/Unit2/Unit3/Unit4 structs back into |
The error messages look correct to me, but the example is a bit obfuscated, so it's difficult to be entirely sure. I did briefly try minimising it, but it was not easy to do so; the test case we have seems sufficient. @bors r+ rollup |
📌 Commit 837fe7b has been approved by |
…-62203-ice, r=varkor Delay bug to resolve HRTB ICE Fix rust-lang#62203
…-62203-ice, r=varkor Delay bug to resolve HRTB ICE Fix rust-lang#62203
Rollup of 14 pull requests Successful merges: - #60951 (more specific errors in src/librustc/mir/interpret/error.rs) - #62523 (Delay bug to resolve HRTB ICE) - #62656 (explain how to search in slice without owned data) - #62791 (Handle more cases of typos misinterpreted as type ascription) - #62804 (rustc_typeck: improve diagnostics for _ const/static declarations) - #62808 (Revert "Disable stack probing for gnux32.") - #62817 (Tweak span for variant not found error) - #62842 (Add tests for issue-58887) - #62851 (move unescape module to rustc_lexer) - #62859 (Place::as_place_ref is now Place::as_ref) - #62869 (add rustc_private as a proper language feature gate) - #62880 (normalize use of backticks in compiler messages for librustc_allocator) - #62885 (Change "OSX" to "macOS") - #62889 (Update stage0.txt) Failed merges: r? @ghost
Fix #62203