Skip to content

Stabilize <*mut _>::cast and <*const _>::cast #62713

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Conversation

SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin commented Jul 16, 2019

Fixes #60602.

FCP: #60602 (comment)

@SimonSapin SimonSapin added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Jul 16, 2019
@rust-highfive
Copy link
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2019
@Centril Centril added this to the 1.38 milestone Jul 21, 2019
@Centril
Copy link
Contributor

Centril commented Jul 21, 2019

:shipit:

r? @Centril @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 21, 2019

📌 Commit 8040c54 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned kennytm Jul 21, 2019
@bors
Copy link
Collaborator

bors commented Jul 21, 2019

🌲 The tree is currently closed for pull requests below priority 1500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
bors added a commit that referenced this pull request Jul 22, 2019
Rollup of 14 pull requests

Successful merges:

 - #62709 (Test that maplike FromIter satisfies uniqueness)
 - #62713 (Stabilize <*mut _>::cast and <*const _>::cast)
 - #62746 ( do not use assume_init in std::io)
 - #62787 (Fix typo in src/libstd/net/udp.rs doc comment)
 - #62788 (normalize use of backticks in compiler messages for libcore/ptr)
 - #62799 (use const array repeat expressions for uninit_array)
 - #62810 (normalize use of backticks in compiler messages for librustc_lint)
 - #62812 (normalize use of backticks in compiler messages for librustc_metadata)
 - #62832 (normalize use of backticks in compiler messages for librustc_incremental)
 - #62845 (read: fix doc comment)
 - #62853 (normalize use of backticks in compiler messages for librustc/hir)
 - #62854 (Fix typo in Unicode character name)
 - #62858 (Change wrong variable name.)
 - #62870 (fix lexing of comments with many \r)

Failed merges:

r? @ghost
@bors bors merged commit 8040c54 into rust-lang:master Jul 22, 2019
@SimonSapin SimonSapin deleted the cast branch November 28, 2019 12:04
fishilico added a commit to fishilico/shared that referenced this pull request May 29, 2020
rust/download_web now fails on Fedora 39 (rustc 1.37) with:

    error[E0658]: use of unstable library feature 'ptr_cast'
      --> /root/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:35:30
       |
    35 |     let val = unsafe { &*ptr.cast() };
       |                              ^^^^
       |
       = note: for more information, see rust-lang/rust#60602

    error[E0658]: use of unstable library feature 'ptr_cast'
      --> /root/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:53:52
       |
    53 |     let slice = unsafe { slice::from_raw_parts(ptr.cast(), count) };
       |                                                    ^^^^
       |
       = note: for more information, see rust-lang/rust#60602

    error[E0658]: use of unstable library feature 'ptr_cast'
      --> /root/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:65:66
       |
    65 |     unsafe { slice::from_raw_parts(slice::from_ref(val).as_ptr().cast(), size) }
       |                                                                  ^^^^
       |
       = note: for more information, see rust-lang/rust#60602

This feature is
https://doc.bccnsoft.com/docs/rust-1.36.0-docs-html/unstable-book/library-features/ptr-cast.html,
stabilized in rust-lang/rust#62713 merged in
Rust 1.38 (2019-09-26).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for the cast method of raw pointers
5 participants