Stabilize <*mut _>::cast and <*const _>::cast #62713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
added
T-libs-api
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit 8040c54 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1500, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 22, 2019
Stabilize <*mut _>::cast and <*const _>::cast Fixes rust-lang#60602. FCP: rust-lang#60602 (comment)
bors
added a commit
that referenced
this pull request
Jul 22, 2019
Rollup of 14 pull requests Successful merges: - #62709 (Test that maplike FromIter satisfies uniqueness) - #62713 (Stabilize <*mut _>::cast and <*const _>::cast) - #62746 ( do not use assume_init in std::io) - #62787 (Fix typo in src/libstd/net/udp.rs doc comment) - #62788 (normalize use of backticks in compiler messages for libcore/ptr) - #62799 (use const array repeat expressions for uninit_array) - #62810 (normalize use of backticks in compiler messages for librustc_lint) - #62812 (normalize use of backticks in compiler messages for librustc_metadata) - #62832 (normalize use of backticks in compiler messages for librustc_incremental) - #62845 (read: fix doc comment) - #62853 (normalize use of backticks in compiler messages for librustc/hir) - #62854 (Fix typo in Unicode character name) - #62858 (Change wrong variable name.) - #62870 (fix lexing of comments with many \r) Failed merges: r? @ghost
fishilico
added a commit
to fishilico/shared
that referenced
this pull request
May 29, 2020
rust/download_web now fails on Fedora 39 (rustc 1.37) with:
error[E0658]: use of unstable library feature 'ptr_cast'
--> /root/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:35:30
|
35 | let val = unsafe { &*ptr.cast() };
| ^^^^
|
= note: for more information, see rust-lang/rust#60602
error[E0658]: use of unstable library feature 'ptr_cast'
--> /root/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:53:52
|
53 | let slice = unsafe { slice::from_raw_parts(ptr.cast(), count) };
| ^^^^
|
= note: for more information, see rust-lang/rust#60602
error[E0658]: use of unstable library feature 'ptr_cast'
--> /root/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:65:66
|
65 | unsafe { slice::from_raw_parts(slice::from_ref(val).as_ptr().cast(), size) }
| ^^^^
|
= note: for more information, see rust-lang/rust#60602
This feature is
https://doc.bccnsoft.com/docs/rust-1.36.0-docs-html/unstable-book/library-features/ptr-cast.html,
stabilized in rust-lang/rust#62713 merged in
Rust 1.38 (2019-09-26).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60602.
FCP: #60602 (comment)