Skip to content

ci: pin awscli dependencies #62856

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 21, 2019
Merged

ci: pin awscli dependencies #62856

merged 1 commit into from
Jul 21, 2019

Conversation

pietroalbini
Copy link
Member

docutils 0.15, a dependency of awscli, broke our CI since it's not compatible with Python 2 due to a bug. This pins all the dependencies of awscli with docutils 0.14, to make sure this kind of regressions doesn't happen again.

r? @Mark-Simulacrum @alexcrichton

@pietroalbini
Copy link
Member Author

@bors p=2000

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2019
@pietroalbini
Copy link
Member Author

@rustbot modify labels: beta-nominated beta-accepted T-infra

We'll need this on beta as well.

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 21, 2019
@rust-highfive

This comment has been minimized.

@pietroalbini
Copy link
Member Author

Resolved the Python 3 incompatibility.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 21, 2019

📌 Commit 18f3534b241a18e442df3d14fcefbe925b6a5133 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2019
@bors
Copy link
Collaborator

bors commented Jul 21, 2019

⌛ Testing commit 18f3534b241a18e442df3d14fcefbe925b6a5133 with merge 64561108ae91c30b97ebe12f5708a475065573a7...

@pietroalbini
Copy link
Member Author

@bors r-

Wait it failed on CI.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2019
@rust-highfive

This comment has been minimized.

docutils 0.15, a dependency of awscli, broke our CI since it's not
compatible with Python 2 due to a bug. This pins all the dependencies of
awscli with docutils 0.14, to make sure this kind of regressions doesn't
happen again.
@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum p=2000

@bors
Copy link
Collaborator

bors commented Jul 21, 2019

📌 Commit ace3684 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2019
@bors
Copy link
Collaborator

bors commented Jul 21, 2019

⌛ Testing commit ace3684 with merge 273f42b...

bors added a commit that referenced this pull request Jul 21, 2019
ci: pin awscli dependencies

docutils 0.15, a dependency of awscli, broke our CI since it's not compatible with Python 2 due to a bug. This pins all the dependencies of awscli with docutils 0.14, to make sure this kind of regressions doesn't happen again.

r? @Mark-Simulacrum @alexcrichton
@rust-highfive

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jul 21, 2019

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 273f42b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2019
@Centril Centril mentioned this pull request Jul 21, 2019
@bors bors merged commit ace3684 into rust-lang:master Jul 21, 2019
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 22, 2019
bors added a commit that referenced this pull request Jul 22, 2019
[beta] Rollup backports

Cherry picked:

* rustc_target: avoid negative register counts in the SysV x86_64 ABI. #62380
* Fix ICEs when `Self` is used in type aliases #62417
* Raise the default recursion limit to 128 #62450
* Handle errors during error recovery gracefully #62604
* Correctly break out of recovery loop #62607
* Cancel unemitted diagnostics during error recovery #62666
* ci: pin awscli dependencies #62856
* Ensure that checkout is with \n line endings #62564

Rolled up:

* [beta] Backport #62615 #62793
* [beta] Fix #62660 #62792

r? @ghost
bors added a commit that referenced this pull request Jul 22, 2019
[beta] Rollup backports

Cherry picked:

* rustc_target: avoid negative register counts in the SysV x86_64 ABI. #62380
* Fix ICEs when `Self` is used in type aliases #62417
* Raise the default recursion limit to 128 #62450
* Handle errors during error recovery gracefully #62604
* Correctly break out of recovery loop #62607
* Cancel unemitted diagnostics during error recovery #62666
* ci: pin awscli dependencies #62856
* Ensure that checkout is with \n line endings #62564

Rolled up:

* [beta] Backport #62615 #62793
* [beta] Fix #62660 #62792

r? @ghost
@pietroalbini pietroalbini deleted the fix-awscli branch August 13, 2019 16:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants