Skip to content

Stabilize checked_duration_since for 1.39.0 #62860

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2019
Merged

Stabilize checked_duration_since for 1.39.0 #62860

merged 2 commits into from
Sep 5, 2019

Conversation

vi
Copy link
Contributor

@vi vi commented Jul 21, 2019

Looks like it has already found some use in projects.

Resolves #58402.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2019
@Centril Centril added this to the 1.38 milestone Jul 21, 2019
@Centril Centril added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Jul 21, 2019
@Centril
Copy link
Contributor

Centril commented Jul 21, 2019

r? @dtolnay

@rust-highfive rust-highfive assigned dtolnay and unassigned cramertj Jul 21, 2019
@est31 est31 mentioned this pull request Jul 22, 2019
Closed
@joelpalmer
Copy link

Ping from Triage. @dtolnay @rust-lang/libs checking on the status of a review for this PR.

@alexcrichton
Copy link
Member

Looks reasonable to me to merge, so let's...

@rfcbot fcp merge

New functions here are:

impl Instant {
    pub fn checked_duration_since(&self, earlier: Instant) -> Option<Duration>;
    pub fn saturating_duration_since(&self, earlier: Instant) -> Duration;
}

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 29, 2019 •
edited by dtolnay
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 29, 2019
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 30, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 30, 2019
@Centril Centril added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2019
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 9, 2019
@rfcbot
Copy link
Collaborator

rfcbot commented Aug 9, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 9, 2019

📌 Commit 01d9e57 has been approved by alexcrichton

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 9, 2019
@Centril
Rollup merge of rust-lang#62860 - vi:stabilize_checked_duration_since…
1b3e7fb 
…, r=alexcrichton

Stabilize checked_duration_since for 1.38.0

Looks like it has already found some use in projects.

Resolves rust-lang#58402.
@Centril Centril removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Aug 9, 2019
@Centril
Copy link
Contributor

Centril commented Sep 1, 2019

r? @Mark-Simulacrum

@alexcrichton alexcrichton mentioned this pull request Sep 4, 2019
Closed
@vi
Copy link
Contributor Author

vi commented Sep 4, 2019

S-waiting-on-author

What to do now?

Shall I try renaming to tidy_test_never_used_anywhere_else and implementing it in Tidy?

@Mark-Simulacrum
Copy link
Member

I believe if you change the line I pointed to have a feature name that is not checked_duration_since, everything should work.

@Mark-Simulacrum
Copy link
Member

r=me with this all squashed into one or two commits (I'd personally separate out the tidy fix but doesn't matter too much) as well as a rebase

@vi
Copy link
Contributor Author

vi commented Sep 4, 2019

r=me

Means "abandon this pull request and submit the new one, specifying r? Mark-Simulacrum in the opening comment"?

Or just rebase and force-push in place?

@vi vi force-pushed the stabilize_checked_duration_since branch from bb1bbe3 to 9d3cfae Compare September 4, 2019 22:57
@vi
Copy link
Contributor Author

vi commented Sep 4, 2019

... submit the new one ..., or rebase and force-push?

Went with the latter. Can rollback if needed.

@vi vi force-pushed the stabilize_checked_duration_since branch from 9d3cfae to 5545582 Compare September 4, 2019 22:58
@Mark-Simulacrum
Copy link
Member

Yep, rebase and force-push is perfect.

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 4, 2019

📌 Commit 5545582 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
@Centril
Rollup merge of rust-lang#62860 - vi:stabilize_checked_duration_since…
f062076 
…, r=Mark-Simulacrum

Stabilize checked_duration_since for 1.38.0

Looks like it has already found some use in projects.

Resolves rust-lang#58402.
@Centril Centril mentioned this pull request Sep 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
@Centril
Rollup merge of rust-lang#62860 - vi:stabilize_checked_duration_since…
ee437eb 
…, r=Mark-Simulacrum

Stabilize checked_duration_since for 1.38.0

Looks like it has already found some use in projects.

Resolves rust-lang#58402.
@Centril Centril mentioned this pull request Sep 5, 2019
Merged
bors added a commit that referenced this pull request Sep 5, 2019
@bors
Auto merge of #64160 - Centril:rollup-vrfj1pt, r=Centril
a24f636 
Rollup of 15 pull requests

Successful merges:

 - #62860 (Stabilize checked_duration_since for 1.38.0)
 - #63549 (Rev::rposition counts from the wrong end)
 - #63985 (Stabilize pin_into_inner in 1.39.0)
 - #64005 (Add a `Place::is_indirect` method to determine whether a `Place` contains a `Deref` projection)
 - #64031 (Harden `param_attrs` test wrt. usage of a proc macro `#[attr]`)
 - #64038 (Check impl trait substs when checking for recursive types)
 - #64043 (Add some more tests for underscore imports)
 - #64092 (Update xLTO compatibility table in rustc book.)
 - #64110 (Refer to "`self` type" instead of "receiver type")
 - #64120 (Move path parsing earlier)
 - #64123 (Added warning around code with reference to uninit bytes)
 - #64128 (unused_parens: account for or-patterns and `&(mut x)`)
 - #64141 (Minimize uses of `LocalInternedString`)
 - #64142 (Fix doc links in `std::cmp` module)
 - #64148 (fix a few typos in comments)

Failed merges:

r? @ghost
@bors bors merged commit 5545582 into rust-lang:master Sep 5, 2019
@bors
Copy link
Collaborator

bors commented Sep 5, 2019

☔ The latest upstream changes (presumably #64160) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2019
@vi
Copy link
Contributor Author

vi commented Sep 5, 2019

The latest upstream changes (presumably <rollup that includes this PR>) made this pull request unmergeable

bors added [S-waiting-on-author] and removed [S-waiting-on-bors]

Bot error?

@Mark-Simulacrum
Copy link
Member

Yeah, there's been an uptick in that recently, not sure why. Should be all good though.

@RalfJung
Copy link
Member

(FWIW, the PR title is wrong now, it should mention 1.39.0.)

@vi vi changed the title Stabilize checked_duration_since for 1.38.0 Stabilize checked_duration_since for 1.39.0 Sep 13, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.

Tracking issue for 'checked_duration_since' feature