Remove needless indirection through Rc #62983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedMatch is already cheap to clone due to Lrc's inside.
rust-highfive
added
the
S-waiting-on-review
|
Since this may have performance implications, let's gather performance data: @bors try |
bors
added a commit
that referenced
this pull request
Jul 25, 2019
Remove needless indirection through Rc NamedMatch is already cheap to clone due to Lrc's inside.
|
☀️ Try build successful - checks-azure |
|
@rust-timer build 126d5c7 |
|
Success: Queued 126d5c7 with parent eedf6ce, comparison URL. |
|
r=me when perf is ready |
petrochenkov
added
S-waiting-on-perf
|
Finished benchmarking try commit 126d5c7, comparison URL. |
|
Perf looks like just noise as I expected, since this isn't really removing an allocation from the hot path and Rc is very cheap. @bors r=petrochenkov rollup |
|
📌 Commit 0e022f8 has been approved by |
bors
added
the
S-waiting-on-bors
Mark-Simulacrum
removed
the
S-waiting-on-perf
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 26, 2019
… r=petrochenkov Remove needless indirection through Rc NamedMatch is already cheap to clone due to Lrc's inside.
bors
added a commit
that referenced
this pull request
Jul 26, 2019
Rollup of 14 pull requests Successful merges: - #62084 (allow clippy::unreadable_literal in unicode tables) - #62421 (Introduce `as_deref` to Option) - #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.) - #62801 (Remove support for -Zlower-128bit-ops) - #62828 (Remove vector fadd/fmul reduction workarounds) - #62862 (code cleanup) - #62897 (Attempt to fix backtrace tests on i686-msvc) - #62904 (Disable d32 on armv6 hf targets) - #62907 (Initialize the MSP430 AsmParser) - #62956 (Implement slow-path for FirstSets::first) - #62963 (Allow lexer to recover from some homoglyphs) - #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar) - #62983 (Remove needless indirection through Rc) - #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 26, 2019
… r=petrochenkov Remove needless indirection through Rc NamedMatch is already cheap to clone due to Lrc's inside.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 26, 2019
… r=petrochenkov Remove needless indirection through Rc NamedMatch is already cheap to clone due to Lrc's inside.
bors
added a commit
that referenced
this pull request
Jul 26, 2019
Rollup of 22 pull requests Successful merges: - #62084 (allow clippy::unreadable_literal in unicode tables) - #62120 (Add missing type links in documentation) - #62310 (Add missing doc links in boxed module) - #62421 (Introduce `as_deref` to Option) - #62583 (Implement Unpin for all raw pointers) - #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.) - #62801 (Remove support for -Zlower-128bit-ops) - #62828 (Remove vector fadd/fmul reduction workarounds) - #62862 (code cleanup) - #62904 (Disable d32 on armv6 hf targets) - #62907 (Initialize the MSP430 AsmParser) - #62956 (Implement slow-path for FirstSets::first) - #62963 (Allow lexer to recover from some homoglyphs) - #62964 (clarify and unify some type test names) - #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar) - #62980 (std: Add more accessors for `Metadata` on Windows) - #62983 (Remove needless indirection through Rc) - #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter) - #63002 (error_index_generator should output stdout/stderr when it panics.) - #63004 (Add test for issue-54062) - #63007 (ci: debug network failures while downloading awscli from PyPI) - #63009 (Remove redundant `mut` from variable declaration.) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedMatch is already cheap to clone due to Lrc's inside.