In which we constantly improve the Vec(Deque) array PartialEq impls #63061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
that referenced
this pull request
Jul 28, 2019
In which we constantly improve the Vec(Deque) array PartialEq impls Use the same approach as in #62435 as sanctioned by #61415 (comment). r? @scottmcm
scottmcm
reviewed
Jul 28, 2019
|
Diff looks good; r=me when you're through whatever perf stuff you're verifying. |
|
☀️ Try build successful - checks-azure |
|
@rust-timer build 39cf970 |
|
Argh... the timer bot seems broken... Let's not wait for it =P @bors r=scottmcm |
|
📌 Commit bfdfa85 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 28, 2019
…ttmcm In which we constantly improve the Vec(Deque) array PartialEq impls Use the same approach as in rust-lang#62435 as sanctioned by rust-lang#61415 (comment). r? @scottmcm
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 28, 2019
…ttmcm In which we constantly improve the Vec(Deque) array PartialEq impls Use the same approach as in rust-lang#62435 as sanctioned by rust-lang#61415 (comment). r? @scottmcm
bors
added a commit
that referenced
this pull request
Jul 28, 2019
Rollup of 8 pull requests Successful merges: - #62550 (Implement RFC 2707 + Parser recovery for range patterns) - #62759 (Actually add rustc-guide to toolstate, don't fail builds for the guide) - #62806 (Fix few Clippy warnings) - #62974 (bump crossbeam-epoch dependency) - #63051 (Avoid ICE when referencing desugared local binding in borrow error) - #63061 (In which we constantly improve the Vec(Deque) array PartialEq impls) - #63067 (Add test for issue-50900) - #63071 (Allow rustbot to add `F-*` + `requires-nightly`.) Failed merges: r? @ghost
|
@rust-timer build 39cf970 |
|
Success: Queued 39cf970 with parent c798dff, comparison URL. |
|
Finished benchmarking try commit 39cf970, comparison URL. |
|
Nice; this caused some 0.5% to 2.2% improvements in some cases. 🎉 |
16 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same approach as in #62435 as sanctioned by #61415 (comment).
r? @scottmcm