Some more libsyntax::attr cleanup #63272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
petrochenkov
reviewed
Aug 5, 2019
src/libsyntax/attr/mod.rs
Outdated
| @@ -347,16 +347,17 @@ impl Attribute { | |||
|
|
|||
| pub fn mk_name_value_item_str(ident: Ident, value: Spanned<Symbol>) -> MetaItem { | |||
| let lit_kind = LitKind::Str(value.node, ast::StrStyle::Cooked); | |||
| mk_name_value_item(ident.span.to(value.span), ident, lit_kind, value.span) | |||
| let pos = ident.span.to(value.span); | |||
| mk_name_value_item(ident.with_span_pos(pos), lit_kind, value.span) | |||
There was a problem hiding this comment.
I'd rather move the span concatenation logic into mk_name_value_item and avoid changing the ident span.
|
r=me with the comment addressed and rustdoc fixed |
petrochenkov
added
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
clean-attr
branch
from
d6d782a to
8849149
Compare
|
@bors r=petrochenkov rollup |
|
📌 Commit 8849149 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 5, 2019
…chenkov Some more libsyntax::attr cleanup Much smaller patch than the last one, mostly just finishing up by removing some Span arguments. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
…chenkov Some more libsyntax::attr cleanup Much smaller patch than the last one, mostly just finishing up by removing some Span arguments. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
…chenkov Some more libsyntax::attr cleanup Much smaller patch than the last one, mostly just finishing up by removing some Span arguments. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
…chenkov Some more libsyntax::attr cleanup Much smaller patch than the last one, mostly just finishing up by removing some Span arguments. r? @petrochenkov
bors
added a commit
that referenced
this pull request
Aug 6, 2019
Rollup of 14 pull requests Successful merges: - #61457 (Implement DoubleEndedIterator for iter::{StepBy, Peekable, Take}) - #63017 (Remove special code-path for handing unknown tokens) - #63184 (Explaining the reason why validation is performed in to_str of path.rs) - #63230 (Make use of possibly uninitialized data [E0381] a hard error) - #63260 (fix UB in a test) - #63264 (Revert "Rollup merge of #62696 - chocol4te:fix_#62194, r=estebank") - #63272 (Some more libsyntax::attr cleanup) - #63285 (Remove leftover AwaitOrigin) - #63287 (Don't store &Span) - #63293 (Clarify align_to's requirements and obligations) - #63295 (improve align_offset docs) - #63299 (Make qualify consts in_projection use PlaceRef) - #63312 (doc: fix broken sentence) - #63315 (Fix #63313) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much smaller patch than the last one, mostly just finishing up by removing some Span arguments.
r? @petrochenkov