-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
libsyntax: Refactor parser.rs
into reasonably sized logical units
#63469
Conversation
@bors r+ |
📌 Commit bcfcbfc has been approved by |
@bors p=30 |
libsyntax: Refactor `parser.rs` into reasonably sized logical units Here we split `parser.rs` (~7.9 KLOC) into more reasonably sized files (all < 1.8 KLOC): - `./src/libsyntax/parse/` - `parser.rs` - `parser/` - `pat.rs` - `expr.rs` - `stmt.rs` - `ty.rs` - `path.rs` - `generics.rs` - `item.rs` - `module.rs` Closes #60015. r? @petrochenkov
☀️ Test successful - checks-azure |
IMO |
Dammit, didn't notice that. |
Sure, seems reasonable; let's merge them soonish; I have some other refactors I'd like to do first tho. |
Also, while we are at it, |
(Better to do it faster so people don't have to rebase again.) |
Here we split
parser.rs
(~7.9 KLOC) into more reasonably sized files (all < 1.8 KLOC):./src/libsyntax/parse/
parser.rs
parser/
pat.rs
expr.rs
stmt.rs
ty.rs
path.rs
generics.rs
item.rs
module.rs
Closes #60015.
r? @petrochenkov