Bump to 1.39 #63534

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merged

bors merged 4 commits into rust-lang:master from Mark-Simulacrum:stage0-bump

Aug 15, 2019

Member

Mark-Simulacrum commented Aug 13, 2019


          Bump to 1.39

e9b3a01

rust-highfive assigned Centril

rust-highfive added the S-waiting-on-review label

Mark-Simulacrum mentioned this pull request

Utilize -Zbinary-dep-depinfo in rustbuild #63470

Merged

petrochenkov reviewed

View reviewed changes

src/bootstrap/bin/rustc.rs Outdated

    
                      let cfg_not_bootstrap = stage != "0" && crate_name != Some("rustc_version");

                      if cfg_not_bootstrap && use_internal_lints(crate_name) {

                      // `rustc_version` mis-reports the `stage`.

                      if crate_name != Some("rustc_version") && use_internal_lints(crate_name) {

Contributor

petrochenkov Aug 13, 2019

The "rustc_version" part was also supposed to be removed during the bump.
("Mis-reports the stage" means reporting "not bootstrap" while it was actually "bootstrap".)

Centril approved these changes

View reviewed changes

Contributor

Centril left a comment

cfg(bootstrap) related changes look good aside from @petrochenkov's note.

r=me when-green with that fixed

Mark-Simulacrum force-pushed the stage0-bump branch from c41e394 to 28d2279 Compare

August 13, 2019 21:24

Member Author

Mark-Simulacrum commented Aug 14, 2019

@bors r=Centril p=10

Collaborator

bors commented Aug 14, 2019

📌 Commit 28d2279 has been approved by Centril

bors added S-waiting-on-bors and removed S-waiting-on-review labels

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request


          Rollup merge of rust-lang#63534 - Mark-Simulacrum:stage0-bump, r=Centril

0e13a05

Bump to 1.39

r? @Centril

Mark-Simulacrum mentioned this pull request

Rollup of 11 pull requests #63540

Closed

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63534 - Mark-Simulacrum:stage0-bump, r=Centril

f5b0572

Bump to 1.39

r? @Centril

Centril mentioned this pull request

Rollup of 16 pull requests #63541

Closed

Contributor

Centril commented Aug 14, 2019

Seems like hashbrown is using mem::uninitialized making the bootstrap bump here fail in #63541 (comment)... @bors r-

bors added S-waiting-on-author and removed S-waiting-on-bors labels

Member

Amanieu commented Aug 14, 2019

@Centril The errors in the log don't seem to have anything to do with hashbrown?

Mark-Simulacrum and others added 3 commits

August 14, 2019 05:39


          Handle cfg(bootstrap) throughout

2601c86


          Disable --cfg bootstrap in libcore

6575a96

This is needed to permit us building core_arch which is a submodule dep
(so we can't snap it to the new beta compiler).


          Update error-format to match new Cargo flags for pipelining

f7ff36d

Mark-Simulacrum force-pushed the stage0-bump branch from 28d2279 to f7ff36d Compare

August 14, 2019 09:40

Member Author

Mark-Simulacrum commented Aug 14, 2019

Yeah, I think that's just cloudabi. Fixed (I think).

@bors r=Centril

Collaborator

bors commented Aug 14, 2019

📌 Commit f7ff36d has been approved by Centril

bors added S-waiting-on-bors and removed S-waiting-on-author labels

Member Author

Mark-Simulacrum commented Aug 14, 2019

@bors p=50

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63534 - Mark-Simulacrum:stage0-bump, r=Centril

2a62053

Bump to 1.39

r? @Centril

Centril mentioned this pull request

Rollup of 10 pull requests #63563

Closed

Contributor

Centril commented Aug 14, 2019

@bors retry rolled up

bors added a commit that referenced this pull request


          Auto merge of #63563 - Centril:rollup-j9nld0c, r=Centril

6edcad1

Rollup of 10 pull requests

Successful merges:

 - #62984 (Add lint for excess trailing semicolons)
 - #63075 (Miri: Check that a ptr is aligned and inbounds already when evaluating `*`)
 - #63490 (libsyntax: cleanup and refactor `pat.rs`)
 - #63495 ( Remove redundant `ty` fields from `mir::Constant` and `hair::pattern::PatternRange`.)
 - #63509 (Point at the right enclosing scope when using `await` in non-async fn)
 - #63528 (syntax: Remove `DummyResult::expr_only`)
 - #63534 (Bump to 1.39)
 - #63537 (expand: Unimplement `MutVisitor` on `MacroExpander`)
 - #63542 (Add NodeId for Arm, Field and FieldPat)
 - #63560 (move test that shouldn't be in test/run-pass/)

Failed merges:

r? @ghost

Collaborator

bors commented Aug 14, 2019

⌛ Testing commit f7ff36d with merge 260c22c85d162bdc9cf938d0da7dbb77c823a7e3...

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63534 - Mark-Simulacrum:stage0-bump, r=Centril

4ea9314

Bump to 1.39

r? @Centril

Centril mentioned this pull request

Rollup of 10 pull requests #63571

Closed

Contributor

Centril commented Aug 14, 2019

@bors retry rolled up

Collaborator

bors commented Aug 14, 2019

⌛ Testing commit f7ff36d with merge 082cf2f...

bors added a commit that referenced this pull request


          Auto merge of #63534 - Mark-Simulacrum:stage0-bump, r=Centril

082cf2f

Bump to 1.39

r? @Centril

Collaborator

bors commented Aug 15, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 082cf2f to master...

bors added the merged-by-bors label

bors mentioned this pull request

Remove uses of mem::uninitialized() from cloudabi #63546

Merged

bors merged commit f7ff36d into rust-lang:master

Contributor

rust-highfive commented Aug 15, 2019

📣 Toolstate changed by #63534!

Tested on commit 082cf2f.
Direct link to PR: #63534

💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request


          📣 Toolstate changed by rust-lang/rust#63534!

3c2cb4d

Tested on commit rust-lang/rust@082cf2f.
Direct link to PR: <rust-lang/rust#63534>

💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

bors mentioned this pull request

Use libunwind from llvm-project submodule for musl targets #63173

Merged

Centril mentioned this pull request

libcore: more cleanups using #![feature(associated_type_bounds)] #63584

Merged

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

37b3a4a

… r=alexreg

libcore: more cleanups using `#![feature(associated_type_bounds)]`

Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.

Closes rust-lang#63393

r? @alexreg
cc @iluuu1994
cc rust-lang#52662

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

69a3206

… r=alexreg

libcore: more cleanups using `#![feature(associated_type_bounds)]`

Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.

Closes rust-lang#63393

r? @alexreg
cc @iluuu1994
cc rust-lang#52662

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

8f2decb

… r=alexreg

libcore: more cleanups using `#![feature(associated_type_bounds)]`

Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.

Closes rust-lang#63393

r? @alexreg
cc @iluuu1994
cc rust-lang#52662

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

… r=alexreg

libcore: more cleanups using `#![feature(associated_type_bounds)]`

Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.

Closes rust-lang#63393

r? @alexreg
cc @iluuu1994
cc rust-lang#52662

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

6727afd

… r=alexreg

libcore: more cleanups using `#![feature(associated_type_bounds)]`

Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.

Closes rust-lang#63393

r? @alexreg
cc @iluuu1994
cc rust-lang#52662

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

e771421

… r=alexreg

libcore: more cleanups using `#![feature(associated_type_bounds)]`

Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.

Closes rust-lang#63393

r? @alexreg
cc @iluuu1994
cc rust-lang#52662

Centril added a commit to Centril/rust that referenced this pull request


          Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

7dbd98f

… r=alexreg

libcore: more cleanups using `#![feature(associated_type_bounds)]`

Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.

Closes rust-lang#63393

r? @alexreg
cc @iluuu1994
cc rust-lang#52662

mati865 mentioned this pull request

./x.py clippy is broken #64147

Closed

Mark-Simulacrum deleted the stage0-bump branch

November 10, 2021 20:28

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

merged-by-bors S-waiting-on-bors