-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Upgrade rand to 0.7 #63806
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade rand to 0.7 #63806
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
If I am reading this PR correctly, recent getrandom only support Linux 2.6.22+. That would be a problem as Rust supports 2.6.18+. |
It was later decided to add support for older kernels to be on pair with Rust: rust-random/getrandom#58 (comment) I'll update this PR once tests pass. |
18f474c
to
74b3548
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license of the wasi
crate is not Apache2/MIT but Apache2 with LLVM exception. That's compatible with the Rust run-time, so this LGTM.
I've opened an issue with them to try to relicense it also under MIT as well, but that can be done later - and if it for whatever reason it cannot be done, then that's not critical either.
@alexcrichton could you review this? I'm not a reviewer for rust-lang/rust |
@bors: r+ |
📌 Commit 74b3548 has been approved by |
⌛ Testing commit 74b3548 with merge 391cdd3bd50db0e942a08a8d731a02fe879b76ea... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
Ready to go. @rustbot modify labels: -S-blocked +S-waiting-on-review |
@bors: r+ |
📌 Commit 32101ad has been approved by |
⌛ Testing commit 32101ad with merge 2b58d1cff23a1ead45c0f0180996e26c3c2da14d... |
💥 Test timed out |
Kindly asking the the retry ( |
@bors: retry |
Upgrade rand to 0.7 Also upgrades `getrandom` to avoid bug encountered by rust-lang#61393 which bumps libc to `0.2.62`.
Rollup of 5 pull requests Successful merges: - #63806 (Upgrade rand to 0.7) - #64054 (Always emit unresolved import errors and hide unused import lint) - #64279 (Bump RLS and Rustfmt submodules to use rustc-ap-* v583) - #64317 (Update LLVM submodule) - #64320 (Update version of `rustc-std-workspace-*` crates) Failed merges: r? @ghost
Rollup of 5 pull requests Successful merges: - #63806 (Upgrade rand to 0.7) - #64054 (Always emit unresolved import errors and hide unused import lint) - #64279 (Bump RLS and Rustfmt submodules to use rustc-ap-* v583) - #64317 (Update LLVM submodule) - #64320 (Update version of `rustc-std-workspace-*` crates) Failed merges: r? @ghost
Test FreeBSD 12 on latest nightly ~~Let's see if [libc update](rust-lang/rust#63806) for Rust fixed it.~~ Fixes #1489
Test FreeBSD 12 on latest nightly ~~Let's see if [libc update](rust-lang/rust#63806) for Rust fixed it.~~ Fixes #1489
Also upgrades
getrandom
to avoid bug encountered by #61393 which bumps libc to0.2.62
.