Skip to content

improper_ctypes: guard against accidental change to Unique<T> #63991

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2019
Merged

improper_ctypes: guard against accidental change to Unique<T> #63991

merged 1 commit into from
Aug 31, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Aug 29, 2019

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2019
hanna-kruppe
hanna-kruppe approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@hanna-kruppe hanna-kruppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after fixing the typo

Centril
Centril commented Aug 29, 2019
View reviewed changes
@Centril
Copy link
Contributor Author

Centril commented Aug 29, 2019

r? @rkruppe @bors r=rkruppe rollup

@bors
Copy link
Collaborator

bors commented Aug 29, 2019

📌 Commit 5552945 has been approved by rkruppe

@rust-highfive rust-highfive assigned hanna-kruppe and unassigned eddyb Aug 29, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 29, 2019
@Centril
Rollup merge of rust-lang#63991 - Centril:unique-improper-ctype, r=rk…
ea5bf7a 
…ruppe

`improper_ctypes`: guard against accidental change to `Unique<T>`

r? @eddyb
@Centril Centril mentioned this pull request Aug 29, 2019
Closed
@rust-highfive

This comment has been minimized.

# to view
@Centril

This comment has been minimized.

# to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2019
@Centril Centril force-pushed the unique-improper-ctype branch from 5552945 to 960ecdc Compare August 31, 2019 00:42
@Centril
Copy link
Contributor Author

Centril commented Aug 31, 2019

@bors r=rkruppe rollup

@bors
Copy link
Collaborator

bors commented Aug 31, 2019

📌 Commit 960ecdc has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2019
@bors
Copy link
Collaborator

bors commented Aug 31, 2019

⌛ Testing commit 960ecdc with merge b314654...

bors added a commit that referenced this pull request Aug 31, 2019
@bors
Auto merge of #63991 - Centril:unique-improper-ctype, r=rkruppe
b314654 
`improper_ctypes`: guard against accidental change to `Unique<T>`

r? @eddyb
@bors
Copy link
Collaborator

bors commented Aug 31, 2019

☀️ Test successful - checks-azure
Approved by: rkruppe
Pushing b314654 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 31, 2019
@bors bors merged commit 960ecdc into rust-lang:master Aug 31, 2019
@Centril Centril deleted the unique-improper-ctype branch August 31, 2019 10:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hanna-kruppe hanna-kruppe hanna-kruppe approved these changes

Assignees

@hanna-kruppe hanna-kruppe

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Centril @bors @rust-highfive @hanna-kruppe @eddyb