Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing links on AsRef trait #63999

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

GuillaumeGomez
Copy link
Member

cc @rust-lang/docs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2019
@Mark-Simulacrum
Copy link
Member

r=me from a concrete perspective but IIRC there were some policy discussions with @QuietMisdreavus on this topic? I forget their resolution.

r? @QuietMisdreavus as a result

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 30, 2019

This discussion has been resolved. To sum it up, @QuietMisdreavus proposed to not repeatedly generate docs to same pages but majority didn't agree so we decided to continue this politic.

@bors: r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Aug 30, 2019

📌 Commit 0e74246 has been approved by Mazk-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2019
@bors
Copy link
Contributor

bors commented Aug 30, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 30, 2019

📌 Commit 0e74246 has been approved by Mark-Simulacrum

Centril added a commit to Centril/rust that referenced this pull request Aug 30, 2019
…, r=Mark-Simulacrum

Add missing links on AsRef trait

cc @rust-lang/docs
bors added a commit that referenced this pull request Aug 30, 2019
Rollup of 7 pull requests

Successful merges:

 - #62957 (Match the loop examples)
 - #63600 (Merge oli-obk mail addresses)
 - #63684 (Constify LinkedList new function)
 - #63847 ([rustdoc] Fix system theme detection)
 - #63999 (Add missing links on AsRef trait)
 - #64014 ( miri: detect too large dynamically sized objects )
 - #64015 (some const-eval test tweaks)

Failed merges:

r? @ghost
@bors bors merged commit 0e74246 into rust-lang:master Aug 31, 2019
@GuillaumeGomez GuillaumeGomez deleted the as-ref-missing-links branch August 31, 2019 08:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants