rustc_mir: buffer -Zdump-mir output instead of pestering the kernel constantly. #64344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 1e7faef has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 10, 2019
…kernel, r=oli-obk rustc_mir: buffer -Zdump-mir output instead of pestering the kernel constantly. This brings `mir-opt` tests from `197s` (over 3 minutes!) to `2.85s`, on my build server. That's a nice speedup of about `69x` and so it definitely fixes rust-lang#58485, for me. It's such a beginner mistake I feel like maybe `clippy` should lint against it? (cc @Manishearth @oli-obk)
bors
added a commit
that referenced
this pull request
Sep 10, 2019
Rollup of 8 pull requests Successful merges: - #63786 (Make `abs`, `wrapping_abs`, `overflowing_abs` const functions) - #63989 (Add Yaah to clippy toolstain notification list) - #64256 (test/c-variadic: Fix patterns on powerpc64) - #64292 (lowering: extend temporary lifetimes around await) - #64311 (lldb: avoid mixing "Hit breakpoint" message with other output.) - #64330 (Clarify E0507 to note Fn/FnMut relationship to borrowing) - #64331 (Changed instant is earlier to instant is later) - #64344 (rustc_mir: buffer -Zdump-mir output instead of pestering the kernel constantly.) Failed merges: r? @ghost
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 1, 2020
…mulacrum Use BufWriter for emitting MIR I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…mulacrum Use BufWriter for emitting MIR I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…mulacrum Use BufWriter for emitting MIR I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings
mir-opttests from197s(over 3 minutes!) to2.85s, on my build server.That's a nice speedup of about
69xand so it definitely fixes #58485, for me.It's such a beginner mistake I feel like maybe
clippyshould lint against it?(cc @Manishearth @oli-obk)