Skip to content

Account for tail expressions when pointing at return type #64802

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2019
Merged

Account for tail expressions when pointing at return type #64802

merged 4 commits into from
Sep 28, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 26, 2019 •
edited
Loading

When there's a type mismatch we make an effort to check if it was
caused by a function's return type. This logic now makes sure to
only point at the return type if the error happens in a tail
expression.

Turn walk_parent_nodes method into an iterator.

CC #39968, CC #40799.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2019
matthewjasper
matthewjasper reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@matthewjasper matthewjasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comment addressed

@matthewjasper matthewjasper added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2019
@estebank

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 27, 2019
@Centril
Rollup merge of rust-lang#64802 - estebank:walk-parents-iterator, r=m…
ea31935 
…atthewjasper

Account for tail expressions when pointing at return type

When there's a type mismatch we make an effort to check if it was
caused by a function's return type. This logic now makes sure to
only point at the return type if the error happens in a tail
expression.

Turn `walk_parent_nodes` method into an iterator.

CC rust-lang#39968, CC rust-lang#40799.
@Centril Centril mentioned this pull request Sep 27, 2019
Closed
@estebank estebank mentioned this pull request Sep 27, 2019
Merged
@bors

This comment has been minimized.

# to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 27, 2019
@estebank
Turn walk_parent_nodes method into an iterator
faee8e1
@estebank
Account for tail expressions when pointing at return type
46a38dc 
When there's a type mismatch we make an effort to check if it was
caused by a function's return type. This logic now makes sure to
only point at the return type if the error happens in a tail
expression.
@estebank
review comments
e537d06
@estebank estebank force-pushed the walk-parents-iterator branch from fdeb4ca to e537d06 Compare September 27, 2019 16:35
@estebank
Copy link
Contributor Author

@bors r=matthewjasper

@bors
Copy link
Collaborator

bors commented Sep 27, 2019

📌 Commit a284822 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 28, 2019
@Centril
Rollup merge of rust-lang#64802 - estebank:walk-parents-iterator, r=m…
4633816 
…atthewjasper

Account for tail expressions when pointing at return type

When there's a type mismatch we make an effort to check if it was
caused by a function's return type. This logic now makes sure to
only point at the return type if the error happens in a tail
expression.

Turn `walk_parent_nodes` method into an iterator.

CC rust-lang#39968, CC rust-lang#40799.
@Centril Centril mentioned this pull request Sep 28, 2019
Closed
bors added a commit that referenced this pull request Sep 28, 2019
@bors
Auto merge of #64860 - Centril:rollup-h84usom, r=Centril
2d52243 
Rollup of 14 pull requests

Successful merges:

 - #63492 (Remove redundancy from the implementation of C variadics.)
 - #64703 (Docs: slice elements are equidistant)
 - #64745 (Include message on tests that should panic but do not)
 - #64781 (Remove stray references to the old global tcx)
 - #64794 (Remove unused DepTrackingMap)
 - #64802 (Account for tail expressions when pointing at return type)
 - #64809 (hir: Disallow `target_feature` on constants)
 - #64815 (Fix div_duration() marked as stable by mistake)
 - #64818 (update rtpSpawn's parameters type(It's prototype has been updated in libc))
 - #64830 (Thou shallt not `.abort_if_errors()`)
 - #64836 (Stabilize map_get_key_value feature)
 - #64845 (pin.rs: fix links to primitives in documentation)
 - #64847 (Upgrade env_logger to 0.7)
 - #64851 (Add mailmap entry for Dustin Bensing by request)

Failed merges:

 - #64824 (No StableHasherResult everywhere)

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 28, 2019
@Centril
Rollup merge of rust-lang#64802 - estebank:walk-parents-iterator, r=m…
5b6a580 
…atthewjasper

Account for tail expressions when pointing at return type

When there's a type mismatch we make an effort to check if it was
caused by a function's return type. This logic now makes sure to
only point at the return type if the error happens in a tail
expression.

Turn `walk_parent_nodes` method into an iterator.

CC rust-lang#39968, CC rust-lang#40799.
@Centril Centril mentioned this pull request Sep 28, 2019
Merged
bors added a commit that referenced this pull request Sep 28, 2019
@bors
Auto merge of #64864 - Centril:rollup-pxz6tw3, r=Centril
f3c8eba 
Rollup of 14 pull requests

Successful merges:

 - #64703 (Docs: slice elements are equidistant)
 - #64745 (Include message on tests that should panic but do not)
 - #64781 (Remove stray references to the old global tcx)
 - #64794 (Remove unused DepTrackingMap)
 - #64802 (Account for tail expressions when pointing at return type)
 - #64809 (hir: Disallow `target_feature` on constants)
 - #64815 (Fix div_duration() marked as stable by mistake)
 - #64818 (update rtpSpawn's parameters type(It's prototype has been updated in libc))
 - #64830 (Thou shallt not `.abort_if_errors()`)
 - #64836 (Stabilize map_get_key_value feature)
 - #64845 (pin.rs: fix links to primitives in documentation)
 - #64847 (Upgrade env_logger to 0.7)
 - #64851 (Add mailmap entry for Dustin Bensing by request)
 - #64859 (check_match: improve diagnostics for `let A = 2;` with `const A: i32 = 3`)

Failed merges:

r? @ghost
@bors bors merged commit a284822 into rust-lang:master Sep 28, 2019
@nikomatsakis nikomatsakis mentioned this pull request Feb 14, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthewjasper matthewjasper matthewjasper left review comments

Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estebank @rust-highfive @bors @matthewjasper