-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Stabilize slice::repeat
(feature repeat_generic_slice
)
#64877
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Error: Label needs-fcp can only be set by Rust team members Please let |
Signature: impl<T> [T] {
pub fn repeat(&self, n: usize) -> Vec<T> where T: Copy {…}
} Would we want to add a variation of this with @rfcbot fcp merge |
Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
I think we'd just have a single method with internal specialization for T: Copy. |
In that case the signature to stabilize is not this one. |
Oh never mind, I forgot that |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
3ebdd91
to
4a2ae45
Compare
@SimonSapin Did you mean to say |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
I have one question: Can we make it like Python |
@yodaldevoid Err, yes |
@lzutao We already have a |
@bors r+ |
📌 Commit 4a2ae45 has been approved by |
…Sapin Stabilize `slice::repeat` (feature `repeat_generic_slice`) Closes #48784 r? @SimonSapin
☀️ Test successful - checks-azure |
Closes #48784
r? @SimonSapin