Include const generic arguments in metadata #65365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Oct 13, 2019
varkor
approved these changes
Oct 13, 2019
There was a problem hiding this comment.
@Skinny121: this looks great, thank you! I'm really happy to see all the work you've been putting into fixing these const generics issues! :)
I just have one question, but I'm happy with these changes.
varkor
added
S-waiting-on-author
|
@Skinny121: if you could squash your two commits (as the second just undoes something in the first), that'd be great! |
BenLewis-Seequent
force-pushed
the
const-args-metadata
branch
from
3e303a4 to
eb68bbb
Compare
|
Thank you! @bors r+ rollup |
|
📌 Commit eb68bbb has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 15, 2019
…rkor Include const generic arguments in metadata Fixes rust-lang#64707 Fixes rust-lang#61624 Fixes rust-lang#64730 r? @varkor
bors
added a commit
that referenced
this pull request
Oct 15, 2019
Rollup of 10 pull requests Successful merges: - #65170 (rustc_metadata: Privatize private code and remove dead code) - #65260 (Optimize `LexicalResolve::expansion`.) - #65261 (Remove `Option` from `TokenStream`) - #65332 (std::fmt: reorder docs) - #65340 (Several changes to the codegen backend organization) - #65365 (Include const generic arguments in metadata) - #65398 (Bring attention to suggestions when the only difference is capitalization) - #65410 (syntax: add parser recovery for intersection- / and-patterns `p1 @ p2`) - #65415 (Remove an outdated test output file) - #65416 (Minor sync changes) Failed merges: r? @ghost
16 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64707
Fixes #61624
Fixes #64730
r? @varkor