Skip to content

Refactor: Rename db locals to diag #65428

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 15, 2019

#64272 replaced DiagnosticBuilder with Diagnostic in some places. This PR just renames the db variable from db to diag where it wasn't renamed.

r? @Mark-Simulacrum

rust-lang#64272 replaced
`DiagnosticBuilder` with `Diagnostic` in some places. This commit just
renames the DB variable from `db` to `diag` where it wasn't renamed.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2019
@Centril
Copy link
Contributor

Centril commented Oct 15, 2019

r? @Centril @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

📌 Commit 6c75e81 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
Refactor: Rename `db` locals to `diag`

rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This PR just renames the db variable from `db` to `diag` where it wasn't renamed.

r? @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
Refactor: Rename `db` locals to `diag`

rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This PR just renames the db variable from `db` to `diag` where it wasn't renamed.

r? @Mark-Simulacrum
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 4 pull requests

Successful merges:

 - #64035 (Stabilize proc macros generating `macro_rules` items)
 - #65376 (syntax: misc extractions)
 - #65426 (Remove custom `PartialEq` impls for `LocalInternedString`.)
 - #65428 (Refactor: Rename `db` locals to `diag`)

Failed merges:

r? @ghost
@bors bors merged commit 6c75e81 into rust-lang:master Oct 15, 2019
@phansch phansch deleted the rename_db_var branch October 15, 2019 19:02
bors added a commit to rust-lang/rust-clippy that referenced this pull request Apr 17, 2020
Cleanup: Rename 'db' variables to 'diag'

Did the same in rustc a while ago: rust-lang/rust#65428

changelog: none
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants