[DO NOT MERGE] Remove InternedString
#65543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `as_str()`, which unnecessarily involves `LocalInternedString`.
Currently, `Symbol::Debug` and `Symbol::Display` produce the same output; neither wraps the symbol in double quotes. This commit changes `Symbol::Debug` so it wraps the symbol in quotes. This change brings `Symbol`'s behaviour in line with `String` and `InternedString`. The change requires a couple of trivial test output adjustments.
This makes `Symbol` like `InternedString`.
Because it's now entirely equivalent to `Symbol`.
`Clone` and `Copy` haven't been needed for some time. `Eq`, `PartialOrd`, `Ord` are no longer necessary now that `Symbol` is ordered by chars rather than index.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
bors
added a commit
that referenced
this pull request
Oct 18, 2019
[DO NOT MERGE] Remove `InternedString` This is a proof of concept relating to #60869. It does the following: - Makes `Symbol` equivalent to `InternedString`, primarily by Changing `Symbol`'s `PartialOrd`, `Ord`, and `Hash` impls to work on the chars instead of the index. - Removes `InternedString`. It shows that this approach works, but causes some performance regressions. r? @ghost
|
☀️ Try build successful - checks-azure |
|
Queued 0533837 with parent fa0f7d0, future comparison URL. |
|
Finished benchmarking try commit 0533837, comparison URL. |
|
As expected, lots of perf regressions, up to 3.5%. |
|
Wall time doesn't look bad though. |
|
#65657 ended up removing |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept relating to #60869. It does the following:
Symbolequivalent toInternedString, primarily by ChangingSymbol'sPartialOrd,Ord, andHashimpls to work on the chars instead of the index.InternedString.It shows that this approach works, but causes some performance regressions.
r? @ghost