Skip to content

Use structured suggestions for missing associated items #65752

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2019
Merged

Use structured suggestions for missing associated items #65752

merged 2 commits into from
Nov 7, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Oct 24, 2019 •
edited
Loading

When encountering an impl that is missing associated items required by its trait, use structured suggestions at an appropriate place in the impl.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2019
@estebank
Copy link
Contributor Author

r? @Centril

Looking at the changes one commit at a time will be easier to follow.

@rust-highfive rust-highfive assigned Centril and unassigned eddyb Oct 24, 2019
@rust-highfive

This comment has been minimized.

# to view
Centril
Centril reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just some initial feedback; I'll look more in-depth later.

@Centril

This comment has been minimized.

# to view
@estebank estebank force-pushed the sugg branch 2 times, most recently from f73eb2c to ab187ba Compare October 24, 2019 22:36
@rust-highfive

This comment has been minimized.

# to view
@rust-highfive

This comment has been minimized.

# to view
@Centril Centril added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
@Centril Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 28, 2019
Centril
Centril reviewed Oct 29, 2019
View reviewed changes
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2019
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2019
Centril
Centril reviewed Oct 31, 2019
View reviewed changes
@Centril
Copy link
Contributor

Centril commented Oct 31, 2019

r=me with two remaining nits addressed.

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2019
@bors

This comment has been minimized.

# to view
@estebank
Copy link
Contributor Author

estebank commented Nov 6, 2019

@bors r=Centril

@bors
Copy link
Collaborator

bors commented Nov 6, 2019

📌 Commit a12a32a has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2019
@bors
Copy link
Collaborator

bors commented Nov 7, 2019

⌛ Testing commit a12a32a with merge 67e714a18f52bd750356eb37155ed35134022025...

Centril added a commit to Centril/rust that referenced this pull request Nov 7, 2019
@Centril
Rollup merge of rust-lang#65752 - estebank:sugg, r=Centril
a3c8572 
Use structured suggestions for missing associated items

When encountering an `impl` that is missing associated items required by its `trait`, use structured suggestions at an appropriate place in the `impl`.
@Centril Centril mentioned this pull request Nov 7, 2019
Merged
@Centril
Copy link
Contributor

Centril commented Nov 7, 2019

@bors retry rolled up.

bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #66180 - Centril:rollup-c1ji943, r=Centril
50f8aad 
Rollup of 5 pull requests

Successful merges:

 - #59789 (Revert two unapproved changes to rustc_typeck.)
 - #65752 (Use structured suggestions for missing associated items)
 - #65884 (syntax: ABI-oblivious grammar)
 - #65974 (A scheme for more macro-matcher friendly pre-expansion gating)
 - #66017 (Add future incompatibility lint for `array.into_iter()`)

Failed merges:

 - #66056 (rustc_metadata: Some reorganization of the module structure)

r? @ghost
@bors bors merged commit a12a32a into rust-lang:master Nov 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @Centril @bors @eddyb