Skip to content

Avoid ICE when adjusting bad self ty #65755

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2019
Merged

Avoid ICE when adjusting bad self ty #65755

merged 1 commit into from
Oct 25, 2019

Conversation

estebank
Copy link
Contributor

Fix #65611.

@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Oct 24, 2019
@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2019
@estebank estebank added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 24, 2019
davidtwco
davidtwco approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 24, 2019

📌 Commit 18d873e has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2019
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 24, 2019
@nikomatsakis
Copy link
Contributor

Discussed in the @rust-lang/compiler meeting, accepted for beta backport (once it lands).

@nikomatsakis
Copy link
Contributor

We are also giving a "technical 👍" for stable backport, I believe final decision there is made by @rust-lang/release though.

@estebank estebank added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Oct 24, 2019
@Mark-Simulacrum
Copy link
Member

Release team discussed and decided to deny stable backport given that next release is 2 weeks out and this is not a fix in the sense that it is just moving ICEs to errors, not error -> building code or so.

(Procedural note: we don't really have a good process for doing this denial, so I'll just drop both labels.)

@Mark-Simulacrum Mark-Simulacrum removed stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Oct 24, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 24, 2019
@Centril
Rollup merge of rust-lang#65755 - estebank:icicle, r=davidtwco
3312147 
Avoid ICE when adjusting bad self ty

Fix rust-lang#65611.
@Centril Centril mentioned this pull request Oct 24, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 24, 2019
@Centril
Rollup merge of rust-lang#65755 - estebank:icicle, r=davidtwco
7b3896f 
Avoid ICE when adjusting bad self ty

Fix rust-lang#65611.
@Centril Centril mentioned this pull request Oct 24, 2019
Merged
bors added a commit that referenced this pull request Oct 25, 2019
@bors
Auto merge of #65771 - Centril:rollup-upfsvrb, r=Centril
d54111a 
Rollup of 8 pull requests

Successful merges:

 - #65625 (Turn crate store into a resolver output)
 - #65627 (Forbid non-`structural_match` types in const generics)
 - #65710 (Update cargo)
 - #65729 (Update test cases for vxWorks)
 - #65746 (Tweak format string error to point at arguments always)
 - #65753 (Don't assert for different instance on impl trait alias)
 - #65755 (Avoid ICE when adjusting bad self ty)
 - #65766 (Update hashbrown to 0.6.2)

Failed merges:

r? @ghost
@bors bors merged commit 18d873e into rust-lang:master Oct 25, 2019
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 25, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 25, 2019
Merged
bors added a commit that referenced this pull request Oct 26, 2019
@bors
Auto merge of #65708 - Mark-Simulacrum:beta-backports, r=pietroalbini
23f8f65 
[beta] backport rollup

This includes a bunch of PRs:
 *  Fix redundant semicolon lint interaction with proc macro attributes #64387
 *  Upgrade async/await to "used" keywords. #64875
 *  syntax: fix dropping of attribute on first param of non-method assocated fn #64894
 *  async/await: improve not-send errors #64895
 *  Silence unreachable code lint from await desugaring #64930
 *  Always mark rust and rust-call abi's as unwind #65020
 *  Account for macro invocation in `let mut $pat` diagnostic. #65123
 *  Ensure that associated `async fn`s have unique fresh param names #65142
 *  Add troubleshooting section to PGO chapter in rustc book. #65402
 *  Upgrade GCC to 8.3.0, glibc to 1.17.0 and crosstool-ng to 1.24.0 for dist-armv7-linux #65302
 *  Optimize `try_expand_impl_trait_type` #65293
 *  use precalculated dominators in explain_borrow #65172
 *  Fix ICE #64964 #64989
 *  [beta] Revert "Auto merge of #62948 - matklad:failable-file-loading, r=petro… #65273
 *  save-analysis: Don't ICE when resolving qualified type paths in struct members #65353
 *  save-analysis: Nest tables when processing impl block definitions #65511
 *  Avoid ICE when checking `Destination` of `break` inside a closure #65518
 *  Avoid ICE when adjusting bad self ty #65755
 *  workaround msys2 bug #65762
@estebank estebank deleted the icicle branch November 9, 2023 05:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler panics in ambiguous arrayvec type situation
6 participants
@estebank @rust-highfive @davidtwco @bors @nikomatsakis @Mark-Simulacrum