Move help popup generation code #65780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
move-help-popup-generation-code
branch
from
1dcc915 to
7c46ed2
Compare
kinnison
approved these changes
Oct 25, 2019
|
Let's ask someone else to review it as well then! |
JohnCSimon
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #65845) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
move-help-popup-generation-code
branch
from
7c46ed2 to
91ef960
Compare
|
Ping from triage |
|
I guess keyboard shortcuts don't work without JS anyway, right? So this isn't losing functionality (or documentation of that functionality)? |
|
Nope, just reducing generated HTML size and making page load faster for JS-disabled people (which is a complete side-effect, but a nice one I think? haha). |
|
@bors r+ |
|
📌 Commit 91ef960 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 3, 2019
…, r=Mark-Simulacrum Move help popup generation code The first commit is just a small cleanup. The idea behind this PR is to reduce a bit more the generated HTML files by moving the duplicated code into one place instead. r? @kinnison
|
☀️ Test successful - checks-azure |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just a small cleanup.
The idea behind this PR is to reduce a bit more the generated HTML files by moving the duplicated code into one place instead.
r? @kinnison