Skip to content

move Attribute::with_desugared_doc to librustdoc #65789

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 25, 2019

From #65324.

r? @varkor

@Centril
Copy link
Contributor Author

Centril commented Oct 25, 2019

r? @davidtwco :)

@rust-highfive rust-highfive assigned davidtwco and unassigned varkor Oct 25, 2019
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, one or two comments need updated and a couple clarifications.

Co-Authored-By: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co>
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI is green.

@Centril
Copy link
Contributor Author

Centril commented Oct 25, 2019

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Oct 25, 2019

📌 Commit 9e3e3a4 has been approved by davidtwco

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
…twco

move Attribute::with_desugared_doc to librustdoc

From rust-lang#65324.

r? @varkor
bors added a commit that referenced this pull request Oct 25, 2019
Rollup of 9 pull requests

Successful merges:

 - #64639 (Stabilize `#[non_exhaustive]` (RFC 2008))
 - #65074 (Fix the start/end byte positions in the compiler JSON output)
 - #65315 (Intern place projection)
 - #65685 (Fix check of `statx` and handle EPERM)
 - #65731 (Prevent unnecessary allocation in PathBuf::set_extension.)
 - #65740 (Fix default "disable-shortcuts" feature value)
 - #65787 (move panictry! to where it is used.)
 - #65789 (move Attribute::with_desugared_doc to librustdoc)
 - #65790 (move report_invalid_macro_expansion_item to item.rs)

Failed merges:

r? @ghost
@bors bors merged commit 9e3e3a4 into rust-lang:master Oct 25, 2019
@Centril Centril deleted the with-desugared-doc branch October 25, 2019 14:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants