Skip to content

HIR docs: mention how to resolve method paths #66076

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 4, 2019

No description provided.

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2019
@RalfJung RalfJung changed the title QPath docs: mention how to resolve them HIR docs: mention how to resolve method paths Nov 4, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Nov 4, 2019

@oli-obk I hope I got this right.

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me unless you want someone else to take a look.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 6, 2019

yea these are the right functions to call. It's good to have this documented, I've looked for this function a few times and kept rediscovering it and forgetting it again

Co-Authored-By: Oliver Scherer <github35764891676564198441@oli-obk.de>
@RalfJung
Copy link
Member Author

RalfJung commented Nov 6, 2019

@bors r=davidtwco,oli-obk

@bors
Copy link
Collaborator

bors commented Nov 6, 2019

📌 Commit f2ed1e6 has been approved by davidtwco,oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 6, 2019
HIR docs: mention how to resolve method paths
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 6, 2019
HIR docs: mention how to resolve method paths
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 7, 2019
HIR docs: mention how to resolve method paths
bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 12 pull requests

Successful merges:

 - #65794 (gate rustc_on_unimplemented under rustc_attrs)
 - #65945 (Optimize long-linker-command-line test)
 - #66044 (Improve uninit/zeroed lint)
 - #66076 (HIR docs: mention how to resolve method paths)
 - #66084 (Do not require extra LLVM backends for `x.py test` to pass)
 - #66111 (improve from_raw_parts docs)
 - #66114 (Improve std::thread::Result documentation)
 - #66117 (Fixed PhantomData markers in Arc and Rc)
 - #66146 (Remove unused parameters in `__thread_local_inner`)
 - #66147 (Miri: Refactor to_scalar_ptr out of existence)
 - #66162 (Fix broken link in README)
 - #66171 (Update link on CONTRIBUTING.md)

Failed merges:

r? @ghost
@bors bors merged commit f2ed1e6 into rust-lang:master Nov 7, 2019
@RalfJung RalfJung deleted the qpath branch November 7, 2019 08:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants