rustc_plugin: Remove Registry::register_attribute
#66344
Merged
+12
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @SimonSapin @rust-lang/dev-tools |
petrochenkov
force-pushed
the
noregattr
branch
from
659f502 to
cae9923
Compare
|
@petrochenkov Would you be ok with waiting a bit before landing this? The alternative only landed very recently, and upgrading the Rust version used in Servo is currently blocked on fixing some new warnings: servo/servo#24684 |
|
I’ve verified that removing I’m afraid the latter renders the lint ineffective since it relies on |
matthewjasper
added
S-blocked
matthewjasper
approved these changes
Nov 12, 2019
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Nov 12, 2019
This was referenced Nov 12, 2019
|
☔ The latest upstream changes (presumably #66366) made this pull request unmergeable. Please resolve the merge conflicts. |
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Nov 15, 2019
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 15, 2019
Use `#![register_tool]` instead of `Registry::register_attribute` CC rust-lang/rust#66344, rust-lang/rust#66079
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 15, 2019
Use `#![register_tool]` instead of `Registry::register_attribute` CC rust-lang/rust#66344, rust-lang/rust#66079
|
Alright, Servo should be unblocked now: servo/servo#24750 |
SimonSapin
added
S-waiting-on-author
petrochenkov
force-pushed
the
noregattr
branch
from
cae9923 to
8575743
Compare
|
@bors r=matthewjasper |
|
📌 Commit 8575743 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 17, 2019
…sper rustc_plugin: Remove `Registry::register_attribute` Legacy plugins cannot register inert attributes anymore. The preferred replacement is to use `register_tool` ([tracking issue](rust-lang#66079)). ```rust #![register_tool(servo)] #[servo::must_root] struct S; ``` The more direct replacement is `register_attribute` ([tracking issue](rust-lang#66080)) ```rust #![register_attr(must_root)] #[must_root] struct S; ``` , but it requires registering each attribute individually rather than registering the tool once, and is more likely to be removed rather than stabilized.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 17, 2019
…sper rustc_plugin: Remove `Registry::register_attribute` Legacy plugins cannot register inert attributes anymore. The preferred replacement is to use `register_tool` ([tracking issue](rust-lang#66079)). ```rust #![register_tool(servo)] #[servo::must_root] struct S; ``` The more direct replacement is `register_attribute` ([tracking issue](rust-lang#66080)) ```rust #![register_attr(must_root)] #[must_root] struct S; ``` , but it requires registering each attribute individually rather than registering the tool once, and is more likely to be removed rather than stabilized.
bors
added a commit
that referenced
this pull request
Nov 17, 2019
Rollup of 11 pull requests Successful merges: - #65739 (Improve documentation of `Vec::split_off(...)`) - #66271 (syntax: Keep string literals in ABIs and `asm!` more precisely) - #66344 (rustc_plugin: Remove `Registry::register_attribute`) - #66381 (find_deprecation: deprecation attr may be ill-formed meta.) - #66395 (Centralize panic macro documentation) - #66456 (Move `DIAGNOSTICS` usage to `rustc_driver`) - #66465 (add missing 'static lifetime in docs) - #66466 (miri panic_unwind: fix hack for SEH platforms) - #66469 (Use "field is never read" instead of "field is never used") - #66471 (Add test for issue 63116) - #66477 (Clarify transmute_copy documentation example) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy plugins cannot register inert attributes anymore.
The preferred replacement is to use
register_tool(tracking issue).The more direct replacement is
register_attribute(tracking issue), but it requires registering each attribute individually rather than registering the tool once, and is more likely to be removed rather than stabilized.