-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Use structured suggestion when requiring Copy
constraint in type param
#66567
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
r? @Centril |
Ping from triage: |
This comment has been minimized.
This comment has been minimized.
6228b09
to
5dd5dea
Compare
@bors r+ |
📌 Commit 5dd5dea943bec65e19067e3ee85d0cbb9a0d9968 has been approved by |
@@ -2,7 +2,7 @@ error[E0277]: the trait bound `for<'tcx> F: Foo<'tcx>` is not satisfied | |||
--> $DIR/hrtb-higher-ranker-supertraits.rs:18:26 | |||
| | |||
LL | where F : Foo<'x> | |||
| - help: consider further restricting type parameter `F`: `, for<'tcx> F: Foo<'tcx>` | |||
| - help: consider further restricting type parameter `F`: `, F: for<'tcx> Foo<'tcx>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #66762 to account for these.
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #66561) made this pull request unmergeable. Please resolve the merge conflicts. |
@Dylan-DPC Please avoid merge commits as we do not allow them. @estebank could you squash and r=me ? |
Sorry 😆 resolved the conflict on GH and then realised gh does a merge instead of rebase. |
7956ca1
to
0f530ec
Compare
@bors r=Centril @Centril @Dylan-DPC done |
📌 Commit 0f530ec has been approved by |
Use structured suggestion when requiring `Copy` constraint in type param
☀️ Test successful - checks-azure |
📣 Toolstate changed by #66567! Tested on commit 861e96f. 💔 rustc-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra). |
Tested on commit rust-lang/rust@861e96f. Direct link to PR: <rust-lang/rust#66567> 💔 rustc-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra).
No description provided.